[SPARK-13993][PySpark] Add pyspark Rformula/RforumlaModel save/load #11807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test it please |
|
Test build #53487 has finished for PR 11807 at commit
|
|
@jkbradley This is a follow-up for #9884 |
| @@ -2385,7 +2385,31 @@ class RFormula(JavaEstimator, HasFeaturesCol, HasLabelCol): | |||
| |0.0|0.0| a|[0.0,1.0]| 0.0| | |||
| +---+---+---+---------+-----+ | |||
| ... | |||
| >>> rf.fit(df, {rf.formula: "y ~ . - s"}).transform(df).show() | |||
| >>> model = rf.fit(df, {rf.formula: "y ~ . - s"}) | |||
There was a problem hiding this comment.
How about reusing the fit model from above?
There was a problem hiding this comment.
Do you mean use the rf.fit(df) other than this rf.fit(df, {rf.formula: "y ~ . - s"}) ?
There was a problem hiding this comment.
Oh, sorry, I originally thought this was a new fit() being added, and I wanted to avoid unnecessary model fitting. I now see it was already there, so it's fine either way.
|
Test build #53602 has finished for PR 11807 at commit
|
|
LGTM |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-13993 ## How was this patch tested? doctest Author: Xusen Yin <yinxusen@gmail.com> Closes apache#11807 from yinxusen/SPARK-13993.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-13993
How was this patch tested?
doctest