[SPARK-13958]Executor OOM due to unbounded growth of pointer array in… #11794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @davies |
| array = allocateArray(used / 8 * 2); | ||
| } catch (OutOfMemoryError e) { | ||
| // should have trigger spilling | ||
| assert(inMemSorter.hasSpaceForAnotherRecord()); |
There was a problem hiding this comment.
Could you change this to require and add a error message?
There was a problem hiding this comment.
Hmm.. I tried changing it to require but compiler does not seem to like it. May be because its a java file and can't import scala methods?
|
Jenkins, ok to test. |
|
LGTM |
|
Test build #53543 has finished for PR 11794 at commit
|
|
Merging this into master and 1.6, thanks! |
asfgit
pushed a commit
that referenced
this pull request
Mar 18, 2016
## What changes were proposed in this pull request? This change fixes the executor OOM which was recently introduced in PR #11095 (Please fill in changes proposed in this fix) ## How was this patch tested? Tested by running a spark job on the cluster. (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) … Sorter Author: Sital Kedia <skedia@fb.com> Closes #11794 from sitalkedia/SPARK-13958. (cherry picked from commit 2e0c528) Signed-off-by: Davies Liu <davies.liu@gmail.com>
|
Test build #53550 has finished for PR 11794 at commit
|
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? This change fixes the executor OOM which was recently introduced in PR apache#11095 (Please fill in changes proposed in this fix) ## How was this patch tested? Tested by running a spark job on the cluster. (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) … Sorter Author: Sital Kedia <skedia@fb.com> Closes apache#11794 from sitalkedia/SPARK-13958.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change fixes the executor OOM which was recently introduced in PR #11095
(Please fill in changes proposed in this fix)
How was this patch tested?
Tested by running a spark job on the cluster.
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
… Sorter