[SPARK-13839][SQL] Defer input evaluation and fix Cast issue in IsNotNull filtering for Filter codegen #11676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-13839
What changes were proposed in this pull request?
This PR improves Filter codegen by:
IsNotNull(a)to find the attributes needed to filter out null values. However, the expressionIsNotNull(Cast(a, dt))will not be checked by this. We should add pattern to find this.How was this patch tested?
Existing tests.