[Spark-13705][Docs]UpdateStateByKey Operation documentation incorrectly refers to StatefulNetworkWordCount #11545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2016 16:25
…Operation and goes onto give an example. However for complete code sample it referes to {{site.SPARK_GITHUB_URL}}/blob/master/examples/src/main/scala/org/apache
/spark/examples/streaming/StatefulNetworkWordCount.scala). StatefulNetworkWordCount.scala has changed to demonstrate more recent API mapWithState.
This creates confusion in the document.
Till the time more detailed explanation of mapWIthState is added the reference to StatefulNetworkWordCount.scala should be removed.
…teByKey Operation and goes onto give an example. However for complete code sample it referes to {{site.SPARK_GITHUB_URL}}/blob/master/examples/src/main/scala/org/apache"
This reverts commit 65a34c7.
|
Can one of the admins verify this patch? |
…Operation and goes onto give an example. However for complete code sample it referes to {{site.SPARK_GITHUB_URL}}/blob/master/examples/src/main/scala/org/apache
/spark/examples/streaming/StatefulNetworkWordCount.scala). StatefulNetworkWordCount.scala has changed to demonstrate more recent API mapWithState.
This creates confusion in the document.
Till the time more detailed explanation of mapWIthState is added the reference to StatefulNetworkWordCount.scala should be removed.
rishitesh
changed the title
|
@rishitesh you need to read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a JIRA or PR. You didn't link them. |
rishitesh
changed the title
rishitesh
changed the title
|
Merged to master/1.6 |
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2016
…tly refers to StatefulNetworkWordCount ## What changes were proposed in this pull request? The reference to StatefulNetworkWordCount.scala from updateStatesByKey documentation should be removed, till there is a example for updateStatesByKey. ## How was this patch tested? Have tested the new documentation with jekyll build. Author: rmishra <rmishra@pivotal.io> Closes #11545 from rishitesh/SPARK-13705. (cherry picked from commit 4b13896) Signed-off-by: Sean Owen <sowen@cloudera.com>
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…tly refers to StatefulNetworkWordCount ## What changes were proposed in this pull request? The reference to StatefulNetworkWordCount.scala from updateStatesByKey documentation should be removed, till there is a example for updateStatesByKey. ## How was this patch tested? Have tested the new documentation with jekyll build. Author: rmishra <rmishra@pivotal.io> Closes apache#11545 from rishitesh/SPARK-13705.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The reference to StatefulNetworkWordCount.scala from updateStatesByKey documentation should be removed, till there is a example for updateStatesByKey.
How was this patch tested?
Have tested the new documentation with jekyll build.