Skip to content

[MINOR] Fix typos in comments and testcase name of code #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[MINOR] Fix typos in comments and testcase name of code #11481

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR fixes typos in comments and testcase name of code.

How was this patch tested?

manual.

@dongjoon-hyun
Copy link
Member Author

Since it's not about documents and contains testcase name typo, so I couldn't choose DOCS as component name.

@sarutak
Copy link
Member

sarutak commented Mar 3, 2016

ok to test.

@rxin
Copy link
Contributor

rxin commented Mar 3, 2016

LGTM pending tests

@dongjoon-hyun
Copy link
Member Author

Thank you, @sarutak and @rxin !

@dongjoon-hyun
Copy link
Member Author

Hi, @sarutak and @rxin .

WithAggregationKinesisBackedBlockRDDSuite took about 2 hours and still is running.
The following is the last part of Jenkins logs. It seems abnormal. Could you trigger another test run please?

[info] WithAggregationKinesisBackedBlockRDDSuite:
Using endpoint URL https://kinesis.us-west-2.amazonaws.com for creating Kinesis streams for tests.
[2016-03-02 18:39:50.670894] [0x00007f2565bb6700] [info] [kinesis_producer.cc:79] Created pipeline for stream "KinesisTestUtils-2198454940508828809"
[2016-03-02 18:39:50.671040] [0x00007f2565bb6700] [info] [shard_map.cc:83] Updating shard map for stream "KinesisTestUtils-2198454940508828809"
[2016-03-02 18:39:50.929527] [0x00007f25647b4700] [info] [shard_map.cc:163] Successfully updated shard map for stream "KinesisTestUtils-2198454940508828809" found 2 shards
[info] - Basic reading from Kinesis (2 seconds, 186 milliseconds)
[info] - Read data available in both block manager and Kinesis (77 milliseconds)

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #2604 has started for PR 11481 at commit dd43417.

@dongjoon-hyun
Copy link
Member Author

Oh, thank you for re-triggering.

@sarutak
Copy link
Member

sarutak commented Mar 3, 2016

@dongjoon-hyun Once a commiter trigger a test, you can trigger another one by yourself in the same PR by saying like "retest this please" .

@dongjoon-hyun
Copy link
Member Author

Thank you for your advice!
Is the magic word of a committer Jenkins, test this please and ok to test then?

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52348 has finished for PR 11481 at commit dd43417.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Hi, @sarutak and @rxin .
three builds hanged at the same test WithAggregationKinesisBackedBlockRDDSuite.
The first build fails due to timeout, the others seems to fail with the same reason.

I'm not sure this is the case for the followings? Or, any other reason?

  1. File a JIRA issue for WithAggregationKinesisBackedBlockRDDSuite
  2. Pass the test by removing the typo fix on Kinesis-related files
    • KinesisBackedBlockRDDSuite.scala
    • KinesisReceiverSuite.scala

I think it is out of this PR's scope to fix WithAggregationKinesisBackedBlockRDDSuite.

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52369 has finished for PR 11481 at commit dd43417.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Mar 3, 2016

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52389 has finished for PR 11481 at commit dd43417.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Mar 3, 2016

Yeah, I'm certain it's not this PR as it only changes a test name in the kinesis module. Something's wrong with the tests there. I'm not sure what do with this one; unless someone knows the problem and is fixing it, we can maybe just avoid fixing the files in kinesis and sort out the test separately

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #2608 has started for PR 11481 at commit dd43417.

@dongjoon-hyun
Copy link
Member Author

Thank you for confirming. I'll avoid that in this PR.

@dongjoon-hyun
Copy link
Member Author

retest this please.

@SparkQA
Copy link

SparkQA commented Mar 3, 2016

Test build #52402 has finished for PR 11481 at commit 3cffee2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Finally, it passed.
I filed the Kinesis issue as SPARK-13655, too.

@srowen
Copy link
Member

srowen commented Mar 3, 2016

Merged to master

@asfgit asfgit closed this in 941b270 Mar 3, 2016
@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen !

@dongjoon-hyun dongjoon-hyun deleted the minor_fix_typos_in_code branch March 4, 2016 01:02
roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

This PR fixes typos in comments and testcase name of code.

## How was this patch tested?

manual.

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes apache#11481 from dongjoon-hyun/minor_fix_typos_in_code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants