-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[MINOR] Fix typos in comments and testcase name of code #11481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Fix typos in comments and testcase name of code #11481
Conversation
Since it's not about documents and contains testcase name typo, so I couldn't choose |
ok to test. |
LGTM pending tests |
WithAggregationKinesisBackedBlockRDDSuite took about 2 hours and still is running.
|
Test build #2604 has started for PR 11481 at commit |
Oh, thank you for re-triggering. |
@dongjoon-hyun Once a commiter trigger a test, you can trigger another one by yourself in the same PR by saying like "retest this please" . |
Thank you for your advice! |
Test build #52348 has finished for PR 11481 at commit
|
Hi, @sarutak and @rxin . I'm not sure this is the case for the followings? Or, any other reason?
I think it is out of this PR's scope to fix |
Test build #52369 has finished for PR 11481 at commit
|
Jenkins, test this please |
Test build #52389 has finished for PR 11481 at commit
|
Yeah, I'm certain it's not this PR as it only changes a test name in the kinesis module. Something's wrong with the tests there. I'm not sure what do with this one; unless someone knows the problem and is fixing it, we can maybe just avoid fixing the files in kinesis and sort out the test separately |
Test build #2608 has started for PR 11481 at commit |
Thank you for confirming. I'll avoid that in this PR. |
retest this please. |
Test build #52402 has finished for PR 11481 at commit
|
Finally, it passed. |
Merged to master |
Thank you, @srowen ! |
## What changes were proposed in this pull request? This PR fixes typos in comments and testcase name of code. ## How was this patch tested? manual. Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#11481 from dongjoon-hyun/minor_fix_typos_in_code.
What changes were proposed in this pull request?
This PR fixes typos in comments and testcase name of code.
How was this patch tested?
manual.