[SPARK-13390][SQL][branch-1.6]Fix the issue that Iterator.map().toSeq is not Serializable #11334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
Test build #51816 has finished for PR 11334 at commit
|
|
retest this please |
|
Test build #51824 has finished for PR 11334 at commit
|
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Feb 24, 2016
…q is not Serializable ## What changes were proposed in this pull request? `scala.collection.Iterator`'s methods (e.g., map, filter) will return an `AbstractIterator` which is not Serializable. E.g., ```Scala scala> val iter = Array(1, 2, 3).iterator.map(_ + 1) iter: Iterator[Int] = non-empty iterator scala> println(iter.isInstanceOf[Serializable]) false ``` If we call something like `Iterator.map(...).toSeq`, it will create a `Stream` that contains a non-serializable `AbstractIterator` field and make the `Stream` be non-serializable. This PR uses `toArray` instead of `toSeq` to fix such issue in `def createDataFrame(data: java.util.List[_], beanClass: Class[_]): DataFrame`. ## How was the this patch tested? Jenkins tests. Author: Shixiong Zhu <shixiong@databricks.com> Closes #11334 from zsxwing/SPARK-13390.
|
Merged to 1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
scala.collection.Iterator's methods (e.g., map, filter) will return anAbstractIteratorwhich is not Serializable. E.g.,If we call something like
Iterator.map(...).toSeq, it will create aStreamthat contains a non-serializableAbstractIteratorfield and make theStreambe non-serializable.This PR uses
toArrayinstead oftoSeqto fix such issue indef createDataFrame(data: java.util.List[_], beanClass: Class[_]): DataFrame.How was the this patch tested?
Jenkins tests.