[SPARK-12746][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6 #11237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earthson
changed the title
|
@mengxr Hi, Xiangrui, I've copied the code from master to fix SPARK-12746 for branch-1.6. related: #10697 |
|
Jenkins, this is ok to test. |
|
Test build #51458 has finished for PR 11237 at commit
|
|
Please tag this for SPARK-12746 instead |
Earthson
changed the title
| schema: StructType, | ||
| colName: String, | ||
| dataTypes: Seq[DataType], | ||
| msg: String = ""): Unit = { |
Earthson
changed the title
Earthson
changed the title
|
Test build #51513 has finished for PR 11237 at commit
|
|
Jenkins, test this please. |
|
Test build #51522 has finished for PR 11237 at commit
|
|
@srowen Is this ok to merge? |
|
OK by me though ideally @mengxr would merge. I'll do it tomorrow if not |
asfgit
pushed a commit
that referenced
this pull request
Feb 23, 2016
…false) fix for branch-1.6 https://issues.apache.org/jira/browse/SPARK-13359 Author: Earthson Lu <Earthson.Lu@gmail.com> Closes #11237 from Earthson/SPARK-13359.
|
Merged into branch-1.6. Thanks! @Earthson Could you please close this PR manually? PR sent to a specific branch won't be closed automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-13359