[SPARK-12889][SQL] Rename ParserDialect -> ParserInterface. #10817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hvanhovell |
| @@ -32,7 +32,7 @@ import org.apache.spark.sql.types._ | |||
| /** | |||
| * A parser for foreign DDL commands. | |||
| */ | |||
| class DDLParser(fallback: => ParserDialect) | |||
| class DDLParser(fallback: => ParserInterface) | |||
There was a problem hiding this comment.
note: it is somewhat strange that DDLParser has a "parse" method (not parsePlan). I'm leaving that unchanged because this class will likely just go away.
There was a problem hiding this comment.
Yeah I missed that one. AbstractSparkSQLParser already implements this, it should have been overridden.
|
Test build #2402 has finished for PR 10817 at commit
|
|
Going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussions in #10801, I'm submitting a pull request to rename ParserDialect to ParserInterface.