[SPARK-12673][UI] Add missing uri prepending for job description #10618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #48849 has finished for PR 10618 at commit
|
|
Jenkins, retest this please. |
|
Test build #48858 has finished for PR 10618 at commit
|
|
LGTM. |
| @@ -224,7 +224,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends WebUIPage("") { | |||
| } | |||
| val formattedDuration = duration.map(d => UIUtils.formatDuration(d)).getOrElse("Unknown") | |||
| val formattedSubmissionTime = job.submissionTime.map(UIUtils.formatDate).getOrElse("Unknown") | |||
| val jobDescription = UIUtils.makeDescription(lastStageDescription, parent.basePath) | |||
| val basePathUri = UIUtils.prependBaseUri(parent.basePath) | |||
| val jobDescription = UIUtils.makeDescription(lastStageDescription, basePathUri) | |||
|
|
|||
| val detailUrl = | |||
| "%s/jobs/job?id=%s".format(UIUtils.prependBaseUri(parent.basePath), job.jobId) | |||
There was a problem hiding this comment.
If you wanted to clean up the code slightly, you could change this to use basePathUri defined above, then wrap it back to a single line.
There was a problem hiding this comment.
I see, I will change it.
|
Ahh, looks like #10617 happens to fix the same issue as this PR, I haven't noticed that one... |
|
Test build #48886 has finished for PR 10618 at commit
|
|
LGTM. Merging to master, 1.6 and 1.5 |
asfgit
pushed a commit
that referenced
this pull request
Jan 7, 2016
Otherwise the url will be failed to proxy to the right one if in YARN mode. Here is the screenshot:  Author: jerryshao <sshao@hortonworks.com> Closes #10618 from jerryshao/SPARK-12673. (cherry picked from commit 174e72c) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
Jan 7, 2016
Otherwise the url will be failed to proxy to the right one if in YARN mode. Here is the screenshot:  Author: jerryshao <sshao@hortonworks.com> Closes #10618 from jerryshao/SPARK-12673. (cherry picked from commit 174e72c) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the url will be failed to proxy to the right one if in YARN mode. Here is the screenshot: