Skip to content

[SPARK-12499] [build] don't force MAVEN_OPTS #10448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-12499] [build] don't force MAVEN_OPTS #10448

wants to merge 1 commit into from

Conversation

abridgett
Copy link
Contributor

allow the user to override MAVEN_OPTS (2GB wasn't sufficient for me)

@srowen
Copy link
Member

srowen commented Dec 23, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Dec 23, 2015

Test build #2252 has finished for PR 10448 at commit 2f90b4d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class JavaWordBlacklist\n * class JavaDroppedWordsCounter\n * case class AssertNotNull(\n

asfgit pushed a commit that referenced this pull request Dec 24, 2015
@abridgett @JoshRosen
[SPARK-12499][BUILD] don't force MAVEN_OPTS
5987b16 
allow the user to override MAVEN_OPTS (2GB wasn't sufficient for me)

Author: Adrian Bridgett <adrian@smop.co.uk>

Closes #10448 from abridgett/feature/do_not_force_maven_opts.

(cherry picked from commit ead6abf)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@JoshRosen
Copy link
Contributor

I've merged this into master and branch-1.6. Thanks!

@asfgit asfgit closed this in ead6abf Dec 24, 2015
nchammas
nchammas reviewed Mar 15, 2016
View reviewed changes
make-distribution.sh
@@ -159,7 +159,7 @@ fi
# Build uber fat JAR
cd "$SPARK_HOME"

export MAVEN_OPTS="-Xmx2g -XX:MaxPermSize=512M -XX:ReservedCodeCacheSize=512m"
export MAVEN_OPTS="${MAVEN_OPTS:--Xmx2g -XX:MaxPermSize=512M -XX:ReservedCodeCacheSize=512m}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity (since this initially confused me): This is the Bash syntax for parameter substitution with a default value.

Reference: http://www.tldp.org/LDP/abs/html/parameter-substitution.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. POSIX shell too FYI- so should work with pretty much anything: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abridgett @srowen @SparkQA @JoshRosen @nchammas