[SPARK-12304][STREAMING] Make Spark Streaming web UI display more fri… #10318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endly Receiver graphs
|
@zsxwing could you take a look at this again, please? :-) |
|
Jenkins, test this please |
| .map(_.ceil.toLong) | ||
| .getOrElse(0L) | ||
|
|
||
| val content = listener.receivedEventRateWithBatchTime.map { case (streamId, eventRates) => |
There was a problem hiding this comment.
@zsxwing By mistake; gonna add it back.
…more friendly Receiver graphs" This reverts commit 9882333.
…endly Receiver graphs
|
LGTM pending tests |
|
retest this please |
|
Test build #47760 has finished for PR 10318 at commit
|
|
retest this please |
|
Test build #47769 has finished for PR 10318 at commit
|
|
Thanks @proflin, merging to master |
|
@zsxwing Thanks for reviewing and merging so soon. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…endly Receiver graphs
Currently, the Spark Streaming web UI uses the same maxY when displays 'Input Rate Times& Histograms' and 'Per-Receiver Times& Histograms'.
This may lead to somewhat un-friendly graphs: once we have tens of Receivers or more, every 'Per-Receiver Times' line almost hits the ground.
This issue proposes to calculate a new maxY against the original one, which is shared among all the `Per-Receiver Times& Histograms' graphs.
Before:
After:
