[SPARK-12217] [ML] Document invalid handling for StringIndexer #10257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #47545 has finished for PR 10257 at commit
|
|
Pinging @holdenk and @jkbradley |
|
That looks good to me, I don't think a full code example is necessary. |
| @@ -459,6 +459,42 @@ column, we should get the following: | |||
| "a" gets index `0` because it is the most frequent, followed by "c" with index `1` and "b" with | |||
| index `2`. | |||
|
|
|||
| Additionaly, there are two strategies regarding how `StringIndexer` will handle | |||
| unseen labels when you have set up a `StringIndexer` on a dataset which you want | |||
There was a problem hiding this comment.
"set up" --> "fit"
"on a dataset which you want to reuse on another" --> "on one dataset and then use it to transform another dataset"
|
@BenFradet Thanks! I agree you didn't have to write a full example, but it's nice that it explains it very clearly, so I'd keep it. I just had small phrasing comments. |
|
@jkbradley thanks for the comments. |
|
LGTM pending tests |
|
Test build #47600 has finished for PR 10257 at commit
|
|
Test build #2209 has finished for PR 10257 at commit
|
|
Merging with master and branch-1.6 |
asfgit
pushed a commit
that referenced
this pull request
Dec 12, 2015
Added a paragraph regarding StringIndexer#setHandleInvalid to the ml-features documentation. I wonder if I should also add a snippet to the code example, input welcome. Author: BenFradet <benjamin.fradet@gmail.com> Closes #10257 from BenFradet/SPARK-12217. (cherry picked from commit aea676c) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a paragraph regarding StringIndexer#setHandleInvalid to the ml-features documentation.
I wonder if I should also add a snippet to the code example, input welcome.