Skip to content

[SPARK-12138] [SQL] Escape \u in the generated comments of codegen #10155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-12138] [SQL] Escape \u in the generated comments of codegen #10155

wants to merge 2 commits into from

Conversation

gatorsmile
Copy link
Member

When \u appears in a comment block (i.e. in /**/), code gen will break. So, in Expression and CodegenFallback, we escape \u to \u.

@yhuai Please review it. I did reproduce it and it works after the fix. Thanks!

@SparkQA
Copy link

SparkQA commented Dec 5, 2015

Test build #47213 has finished for PR 10155 at commit 0e514db.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

Weird...

My code changes are not related to the failed test case in SparkR.

count(sampled3) < 3 isn't true

@gatorsmile
Copy link
Member Author

retest this please

@gatorsmile
Copy link
Member Author

Found a bug in the function sample of R. Will submit a PR later. Thanks!

@SparkQA
Copy link

SparkQA commented Dec 5, 2015

Test build #47217 has finished for PR 10155 at commit 0e514db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public abstract static class PrefixComputer\n * class SparkPlanInfo(\n * class SQLMetricInfo(\n * case class SparkListenerSQLExecutionStart(\n * case class SparkListenerSQLExecutionEnd(executionId: Long, time: Long)\n

@yhuai
Copy link
Contributor

yhuai commented Dec 6, 2015

Thanks. LGTM. Merging to master and branch 1.6.

asfgit pushed a commit that referenced this pull request Dec 6, 2015
@gatorsmile @yhuai
[SPARK-12138][SQL] Escape \u in the generated comments of codegen
82a71ab 
When \u appears in a comment block (i.e. in /**/), code gen will break. So, in Expression and CodegenFallback, we escape \u to \\u.

yhuai Please review it. I did reproduce it and it works after the fix. Thanks!

Author: gatorsmile <gatorsmile@gmail.com>

Closes #10155 from gatorsmile/escapeU.

(cherry picked from commit 49efd03)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@yhuai
Copy link
Contributor

yhuai commented Dec 6, 2015

Will also merge it to branch 1.5.

@asfgit asfgit closed this in 49efd03 Dec 6, 2015
asfgit pushed a commit that referenced this pull request Dec 6, 2015
@gatorsmile @yhuai
[SPARK-12138][SQL] Escape \u in the generated comments of codegen
93a0510 
When \u appears in a comment block (i.e. in /**/), code gen will break. So, in Expression and CodegenFallback, we escape \u to \\u.

yhuai Please review it. I did reproduce it and it works after the fix. Thanks!

Author: gatorsmile <gatorsmile@gmail.com>

Closes #10155 from gatorsmile/escapeU.

(cherry picked from commit 49efd03)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@yhuai
Copy link
Contributor

yhuai commented Dec 6, 2015

I have also merged it to branch 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gatorsmile @SparkQA @yhuai