-
Notifications
You must be signed in to change notification settings - Fork 226
[DOC] removed deadlinks from the events/conferences; replaced with videoplay list from early Spark Summits #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: asf-site
Are you sure you want to change the base?
Conversation
…ist recordings from previous spark summits. Signed-off-by: Jules Damji <dmatrix@comcast.net>
Signed-off-by: Jules Damji <dmatrix@comcast.net>
Signed-off-by: Jules Damji <dmatrix@comcast.net>
<h3>Events and meetups</h3> | ||
|
||
<h4>Conferences</h4> | ||
<p>The Spark Summit website archives at spark-summit.org, from years 2013 to 2017, are no longer available, so the links to them have been removed. Instead, we have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a difference between the generated HTML and source .md here:
--- a/site/community.html
+++ b/site/community.html
@@ -263,7 +263,7 @@ most of the video recordings.</p>
<li>
<a href="https://www.meetup.com/spark-users/">Bay Area Spark Meetup.</a>
This group has been running since January 2012 in the San Francisco area.
- The meetup page also contains an <a href="https://www.meetup.com/spark-users/events/past/">archive of past meetups</a>, including videos and <a href="https://www.meetup.com/spark-users/files/">slides</a> for most of the recent talks.
+ The meetup page also contains an <a href="https://www.meetup.com/spark-users/events/past/">archive of past meetups</a>.
</li>
<li>
<a href="https://www.meetup.com/Spark-Barcelona/">Barcelona Spark Meetup</a>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there's a difference because I have removed the extraneous line from the community.md "- The meetup page also contains an archive of past meetups, including videos and slides for most of the recent talks", since the slides are no longer availabvle.
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have to match though; .html is generated from .md by jekyll. You can generate with jekyll or simply carefully make sure the output matches what jekyll will output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the line in site/community.html generated by jeklll, after a bundle exec jekyll build
- Bay Area Spark Meetup. This group has been running since January 2012 in the San Francisco area. The meetup page also contains an archive of past meetups.
-
And here is the community.md commited file:
- Bay Area Spark Meetup. This group has been running since January 2012 in the San Francisco area. The meetup page also contains an archive of past meetups.
They seem identical. What am I missing ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, when I do a git diff site/community.html, I get this:
diff --git a/site/community.html b/site/community.html
index 28f6348340..8224d85e4d 100644
--- a/site/community.html
+++ b/site/community.html
@@ -263,7 +263,7 @@ most of the video recordings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably have a different jekyll version - check the README for how to install the exact same version.
However here it's probably easiest to just do what the diff tells you by hand, it's just one line.
In all events we have to appease the build as this can't be merged with the check failure (see below)
Signed-off-by: Jules Damji <dmatrix@comcast.net>
…okay." This reverts commit 9909a48.
…deadlinks_community_page' into br_jsd_remove_more_deadlinks_community_page
Signed-off-by: Jules Damji <dmatrix@comcast.net>
Uh oh!
There was an error while loading. Please reload this page.