-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49376] Introduce ClusterToleration and WorkerInstanceConfig #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending CIs). Thank you, @jiangzho .
@@ -0,0 +1,19 @@ | |||
package org.apache.spark.k8s.operator.spec; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add license.
@@ -0,0 +1,19 @@ | |||
package org.apache.spark.k8s.operator.spec; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the missing ASF license headers.
Merged to main. |
What changes were proposed in this pull request?
This PR proposes
ClusterTolerations
and relocate initWorkers / minWorkers / maxWorkers fromClusterSpec
top level toWorkerInstanceConfig
.Why are the changes needed?
This would align the API schema used by app / cluster.
ClusterTolerations
can also serves timeout config for clusters in future commitsDoes this PR introduce any user-facing change?
No (not released yet)
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Pass unit test / integration test CIs