alias refactoring - use Resource instead of Path when getting aliases - fix recursion when Resource parent not accessible #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of Path when getting aliases - fix recursion when Resource parent not accessible
…ad of Path when getting aliases - typo, and making IntelliJ happier
|
joerghoh
approved these changes
Jun 2, 2025
reschke
added a commit
that referenced
this pull request
Jun 4, 2025
… - fix recursion when Resource parent not accessible (#183) * Reapply "SLING-12787: ResourceResolver: alias refactoring - use Resource instead of Path when getting aliases (#178)" This reverts commit 1366946. * SLING-12787: ResourceResolver: alias refactoring - use Resource instead of Path when getting aliases - fix recursion when Resource parent not accessible * SLING-12787: ResourceResolver: alias refactoring - use Resource instead of Path when getting aliases - typo, and making IntelliJ happier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where the parent of a Resource is null, which previously aborted the recursion, returning an incorrectly populated
PathGenerator.The code now walks the (String) path again, but continues to use
Resources as long as possible (after which only the names are added to the generator, just as before).The actual fix is in e555757; the PR includes the re-revert of the problematic change.