Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use secure connection to npmjs.org #958

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Use secure connection to npmjs.org #958

merged 2 commits into from
Mar 19, 2018

Conversation

oflebbe
Copy link
Contributor

@oflebbe oflebbe commented Mar 18, 2018 •
edited by wu-sheng
Loading

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.
    Even npm Dependencies should be downloaded securely

  • How to fix?
    apply patch ;-)

New feature or improvement

  • Describe the details and related test reports.

@wu-sheng wu-sheng requested a review from hanahmily March 18, 2018 10:10
@wu-sheng
Copy link
Member

@hanahmily Need your review. Does this https secure download fit your develop env in company?

@coveralls
Copy link

coveralls commented Mar 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 19.186% when pulling 72524c2 on oflebbe:master into dcd6a71 on apache:master.

hanahmily
hanahmily approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@hanahmily hanahmily merged commit 8362486 into apache:master Mar 19, 2018
@wu-sheng wu-sheng added this to the 5.0.0-beta milestone Mar 19, 2018
@wu-sheng wu-sheng added the feature New feature label Mar 19, 2018
@wu-sheng wu-sheng modified the milestones: 5.0.0-beta, 5.0.0-alpha Mar 19, 2018
@oflebbe
Copy link
Contributor Author

oflebbe commented Mar 19, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanahmily hanahmily hanahmily approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
5.0.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@oflebbe @wu-sheng @coveralls @hanahmily