Skip to content

Conversation

kezhenxu94
Copy link
Member

This pull request should speed up the checks as it leverages the parallelism of runners, and makes it quicker to rerun in case the tests are unstable because it splits the tests into separated groups. Also, it adds some filtering paths to avoid unnecessary builds

@kezhenxu94 kezhenxu94 added test Test requirements about performance, feature or before release. chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. labels Mar 24, 2020
@kezhenxu94 kezhenxu94 added this to the 7.1.0 milestone Mar 24, 2020
@kezhenxu94 kezhenxu94 requested a review from wu-sheng March 24, 2020 12:17
@kezhenxu94 kezhenxu94 force-pushed the ci/re-orchestrate-plugin-tests branch from 2a60da9 to 032350f Compare March 24, 2020 12:20
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin test document should be updated, adjust about guiding users to add the task into the YAML files.

@kezhenxu94 kezhenxu94 force-pushed the ci/re-orchestrate-plugin-tests branch from 032350f to de97311 Compare March 24, 2020 13:01
@kezhenxu94 kezhenxu94 requested a review from wu-sheng March 24, 2020 13:02
wu-sheng
wu-sheng previously approved these changes Mar 24, 2020
@kezhenxu94
Copy link
Member Author

Some of the test include too many versions, we may want to omit some minor versions to speed up the checks further

@kezhenxu94 kezhenxu94 merged commit e7f66c9 into master Mar 24, 2020
@kezhenxu94 kezhenxu94 deleted the ci/re-orchestrate-plugin-tests branch March 24, 2020 15:35
@wu-sheng
Copy link
Member

Yes. We should. But, We could do some random deletions.

igit-cn added a commit to igit-cn/skywalking that referenced this pull request Aug 4, 2020
[CI] Reorganize the Plugin Tests to speed up the PR checks (apache#4566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants