Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1441 add icon files notice #1442

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Fix #1441 add icon files notice #1442

merged 2 commits into from
Jul 11, 2018

Conversation

hanahmily
Copy link
Contributor

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Fix #1441

Not Found
@hanahmily hanahmily added bug Something isn't working and you are sure it's a bug! UI UI and front end related. labels Jul 11, 2018
@hanahmily hanahmily added this to the 5.0.0-beta2 milestone Jul 11, 2018
@hanahmily hanahmily self-assigned this Jul 11, 2018
@hanahmily hanahmily requested a review from wu-sheng July 11, 2018 00:33
@WillemJiang
Copy link
Member

We should not add the ASF License header to the iconfont.svg if the file is just copied from dant.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 24.592% when pulling ac42175 on bug/notice into d0f15fc on master.

@wu-sheng
Copy link
Member

Yes. @WillemJiang already removed it at UI repository and submodule updated.

@wu-sheng wu-sheng merged commit dc1dfca into master Jul 11, 2018
@wu-sheng wu-sheng deleted the bug/notice branch July 11, 2018 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug! UI UI and front end related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UI font license issue
4 participants