Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zipkin provider can not receive full spans data #1420

Merged
merged 2 commits into from
Jul 4, 2018
Merged

fix zipkin provider can not receive full spans data #1420

merged 2 commits into from
Jul 4, 2018

Conversation

jjtyro
Copy link
Contributor

@jjtyro jjtyro commented Jul 3, 2018 •
edited
Loading

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.
  1. SpanV1JettyHandler not add to JettyServer, so zipkin client invoke to /api/v1/spans failed, retcode 405.
org.springframework.web.client.HttpClientErrorException: 405 HTTP method POST is not supported by this URL
	at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:91) ~[spring-web-4.3.4.RELEASE.jar:4.3.4.RELEASE]
	at org.springframework.web.client.RestTemplate.handleResponse(RestTemplate.java:667) ~[spring-web-4.3.4.RELEASE.jar:4.3.4.RELEASE]
	at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:620) ~[spring-web-4.3.4.RELEASE.jar:4.3.4.RELEASE]
	at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:595) ~[spring-web-4.3.4.RELEASE.jar:4.3.4.RELEASE]
	at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:557) ~[spring-web-4.3.4.RELEASE.jar:4.3.4.RELEASE]
	at com.alipay.sofa.tracer.boot.zipkin.sender.ZipkinRestTemplateSender.post(ZipkinRestTemplateSender.java:110) ~[classes/:na]
	at com.alipay.sofa.tracer.boot.zipkin.sender.ZipkinRestTemplateSender.sendSpans(ZipkinRestTemplateSender.java:77) ~[classes/:na]
	at zipkin.reporter.AsyncReporter$BoundedAsyncReporter.flush(AsyncReporter.java:228) [zipkin-reporter-0.6.12.jar:na]
	at zipkin.reporter.AsyncReporter$Builder.lambda$build$0(AsyncReporter.java:153) [zipkin-reporter-0.6.12.jar:na]
	at zipkin.reporter.AsyncReporter$Builder$$Lambda$1.run(Unknown Source) [zipkin-reporter-0.6.12.jar:na]
	at java.lang.Thread.run(Thread.java:748) [na:1.8.0_171]
  1. When tcp packet is divided into multiple frames, a complete packet cannot be received at one read from InputStream by SpanProcessor, Causing parsing Json failed.
2018-07-03 09:53:17,991 - org.apache.skywalking.apm.collector.receiver.zipkin.provider.handler.SpanV2JettyHandler -73794 [qtp1040385133-154] ERROR [] - Malformed reading List<Span> from json
java.lang.IllegalArgumentException: Malformed reading List<Span> from json
	at zipkin2.internal.JsonCodec.exceptionReading(JsonCodec.java:240) ~[zipkin-2.9.1.jar:?]
	at zipkin2.internal.V1JsonSpanReader.readList(V1JsonSpanReader.java:46) ~[zipkin-2.9.1.jar:?]
	at zipkin2.codec.SpanBytesDecoder$1.decodeList(SpanBytesDecoder.java:50) ~[zipkin-2.9.1.jar:?]
	at zipkin2.codec.SpanBytesDecoder.decodeList(SpanBytesDecoder.java:151) ~[zipkin-2.9.1.jar:?]
	at zipkin2.codec.SpanBytesDecoder$1.decodeList(SpanBytesDecoder.java:63) ~[zipkin-2.9.1.jar:?]
	at org.apache.skywalking.apm.collector.receiver.zipkin.provider.handler.SpanProcessor.convert(SpanProcessor.java:45) ~[receiver-zipkin-provider-5.0.0-beta2-SNAPSHOT.jar:5.0.0-beta2-SNAPSHOT]
	at org.apache.skywalking.apm.collector.receiver.zipkin.provider.handler.SpanV1JettyHandler.doPost(SpanV1JettyHandler.java:61) [receiver-zipkin-provider-5.0.0-beta2-SNAPSHOT.jar:5.0.0-beta2-SNAPSHOT]
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) [javax.servlet-api-3.1.0.jar:3.1.0]
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) [javax.servlet-api-3.1.0.jar:3.1.0]
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841) [jetty-servlet-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:543) [jetty-servlet-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1239) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:481) [jetty-servlet-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1141) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.Server.handle(Server.java:564) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:279) [jetty-io-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:110) [jetty-io-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:124) [jetty-io-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.util.thread.Invocable.invokePreferred(Invocable.java:122) [jetty-util-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.util.thread.strategy.ExecutingExecutionStrategy.invoke(ExecutingExecutionStrategy.java:58) [jetty-util-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:201) [jetty-util-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:133) [jetty-util-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:672) [jetty-util-9.4.2.v20170220.jar:9.4.2.v20170220]
	at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:590) [jetty-util-9.4.2.v20170220.jar:9.4.2.v20170220]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
Caused by: zipkin2.internal.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 2886 path $[2].timestamp
	at zipkin2.internal.gson.stream.JsonReader.syntaxError(JsonReader.java:1568) ~[zipkin-2.9.1.jar:?]
	at zipkin2.internal.gson.stream.JsonReader.checkLenient(JsonReader.java:1409) ~[zipkin-2.9.1.jar:?]
	at zipkin2.internal.gson.stream.JsonReader.doPeek(JsonReader.java:593) ~[zipkin-2.9.1.jar:?]
	at zipkin2.internal.gson.stream.JsonReader.peek(JsonReader.java:425) ~[zipkin-2.9.1.jar:?]
	at zipkin2.internal.JsonCodec$JsonReader.peekNull(JsonCodec.java:113) ~[zipkin-2.9.1.jar:?]
	at zipkin2.internal.V1JsonSpanReader.fromJson(V1JsonSpanReader.java:66) ~[zipkin-2.9.1.jar:?]
	at zipkin2.internal.V1JsonSpanReader.readList(V1JsonSpanReader.java:40) ~[zipkin-2.9.1.jar:?]
	... 30 more
  • How to fix?
  1. Modify ZipkinReceiverProvider, add one line code to add V1 handler.
  2. Modify SpanProcessor, add some code to Read the data cyclically until the reading is complete.

New feature or improvement

  • Describe the details and related test reports.

wu-sheng
wu-sheng reviewed Jul 3, 2018
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pr. Beta2 release is on the way. Let's wait release done, and try to merge this into RC. Is that OK?

@wu-sheng wu-sheng added this to the 5.0.0-RC milestone Jul 3, 2018
@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! backend OAP backend related. labels Jul 3, 2018
@coveralls
Copy link

coveralls commented Jul 3, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 24.442% when pulling 6fa9bd7 on jjtyro:fix/zipkin_provider_not_receive_full_data into 5941e72 on apache:master.

@jjtyro
Copy link
Contributor Author

jjtyro commented Jul 3, 2018

What mean " Coverage decreased (-0.01%) to 24.442% " ?

@wu-sheng
Copy link
Member

wu-sheng commented Jul 3, 2018

What mean " Coverage decreased (-0.01%) to 24.442% " ?

You added some lines, but so test cases cover those lines. You don't need to worry about this.

@wu-sheng wu-sheng merged commit 6a7e344 into apache:master Jul 4, 2018
@jjtyro jjtyro deleted the fix/zipkin_provider_not_receive_full_data branch July 5, 2018 00:49
@wu-sheng wu-sheng mentioned this pull request Jul 25, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
5.0.0-RC2
Development

Successfully merging this pull request may close these issues.
3 participants
@jjtyro @coveralls @wu-sheng