Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase SW_CORE_GRPC_MAX_MESSAGE_SIZE to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. #12321

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Increase SW_CORE_GRPC_MAX_MESSAGE_SIZE to 50MB and e2e bump up the version of the opentelemetry-collector to 0.102.1. #12321

merged 3 commits into from
Jun 11, 2024

Conversation

wankai123
Copy link
Member

@wankai123 wankai123 added bug Something isn't working and you are sure it's a bug! test Test requirements about performance, feature or before release. labels Jun 11, 2024
@wankai123 wankai123 added this to the 10.1.0 milestone Jun 11, 2024
@wankai123 wankai123 requested a review from wu-sheng June 11, 2024 10:36
wu-sheng
wu-sheng reviewed Jun 11, 2024
View reviewed changes
oap-server/server-starter/src/main/resources/application.yml
@@ -81,7 +81,7 @@ core:
gRPCHost: ${SW_CORE_GRPC_HOST:0.0.0.0}
gRPCPort: ${SW_CORE_GRPC_PORT:11800}
maxConcurrentCallsPerConnection: ${SW_CORE_GRPC_MAX_CONCURRENT_CALL:0}
maxMessageSize: ${SW_CORE_GRPC_MAX_MESSAGE_SIZE:0}
maxMessageSize: ${SW_CORE_GRPC_MAX_MESSAGE_SIZE:52428800} #50MB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check sharing server config too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increased

Superskyyy
Superskyyy reviewed Jun 11, 2024
View reviewed changes
docs/en/setup/backend/configuration-vocabulary.md
@@ -38,7 +38,7 @@ The Configuration Vocabulary lists all available configurations provided by `app
| - | - | autocompleteTagValuesQueryMaxSize | The max size of tags values for autocomplete select. | SW_AUTOCOMPLETE_TAG_VALUES_QUERY_MAX_SIZE | 100 |
| - | - | gRPCThreadPoolSize | Pool size of gRPC server. | SW_CORE_GRPC_THREAD_POOL_SIZE | Default to gRPC's implementation, which is a cached thread pool that can grow infinitely. |
| - | - | maxConcurrentCallsPerConnection | The maximum number of concurrent calls permitted for each incoming connection. Defaults to no limit. | SW_CORE_GRPC_MAX_CONCURRENT_CALL | - |
| - | - | maxMessageSize | Sets the maximum message size allowed to be received on the server. Empty means 4 MiB. | SW_CORE_GRPC_MAX_MESSAGE_SIZE | 4M(based on Netty) |
| - | - | maxMessageSize | Sets the maximum message size allowed to be received on the server. Empty means 4 MiB. | SW_CORE_GRPC_MAX_MESSAGE_SIZE | 52428800 (50MB) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default means 50MB?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we noticed this on demo deployment.
We increased application.yml values, so yes, default values changed.

docs/en/setup/backend/configuration-vocabulary.md
@@ -171,6 +171,7 @@ The Configuration Vocabulary lists all available configurations provided by `app
| - | - | gRPCSslKeyPath | File path of gRPC SSL key. | SW_RECEIVER_GRPC_SSL_KEY_PATH | - |
| - | - | gRPCSslCertChainPath | File path of gRPC SSL cert chain. | SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH | - |
| - | - | maxConcurrentCallsPerConnection | The maximum number of concurrent calls permitted for each incoming connection. Defaults to no limit. | SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL | - |
| - | - | maxMessageSize | Sets the maximum message size allowed to be received on the server. Empty means 4 MiB. | SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE | 52428800 (50MB) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@wu-sheng wu-sheng merged commit a6c7c71 into apache:master Jun 11, 2024
154 checks passed
@wankai123 wankai123 deleted the increase-grpc-msg-size branch June 11, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superskyyy Superskyyy Superskyyy left review comments

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working and you are sure it's a bug! test Test requirements about performance, feature or before release.
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

[Bug] [BanyanDB] Metrics breaks periodically
3 participants
@wankai123 @wu-sheng @Superskyyy