Skip to content

Support query browser error log #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 17, 2020
Merged

Support query browser error log #42

merged 5 commits into from
Aug 17, 2020

Conversation

rainbend
Copy link
Member

related to apache/skywalking#4228

Hi @wu-sheng @Fine0830, please give me some suggestions for modification :)

@rainbend rainbend added the enhancement New feature or request label Aug 10, 2020
@rainbend rainbend requested review from wu-sheng and Fine0830 August 10, 2020 15:17
Fine0830
Fine0830 reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@Fine0830 Fine0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you support querying all error logs of a service?

@rainbend
Copy link
Member Author

Do you support querying all error logs of a service?

Yes, I support these conditions:

input BrowserErrorLogQueryCondition {
    # The value of 0 means all services.
    serviceId: ID
    serviceVersionId: ID
    pagePathId: ID
    pagePath: String
    category: ErrorCategory
    # The time range of browser perf data time
    queryDuration: Duration
    paging: Pagination!
}

wu-sheng
wu-sheng reviewed Aug 11, 2020
View reviewed changes
@rainbend
Copy link
Member Author

@wu-sheng @Fine0830 updated, please recheck :)

wu-sheng
wu-sheng reviewed Aug 15, 2020
View reviewed changes
@rainbend
Copy link
Member Author

Result

image

@Fine0830 @wu-sheng please review.

@rainbend rainbend marked this pull request as ready for review August 16, 2020 09:45
wu-sheng
wu-sheng approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Fine0830 Please recheck.

Fine0830
Fine0830 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@Fine0830 Fine0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fine0830 Fine0830 merged commit 92f62f1 into apache:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@Fine0830 Fine0830 Fine0830 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rainbend @wu-sheng @Fine0830