Skip to content

Add sanic plugin #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 27, 2020
Merged

Add sanic plugin #91

merged 18 commits into from
Nov 27, 2020

Conversation

fuhuo
Copy link
Contributor

@fuhuo fuhuo commented Nov 25, 2020

  • Add a test case for the new plugin
  • Add a component id in the main repo
  • Add a logo in the UI repo
  • Rebuild the requirements.txt by running tools/env/build_requirements_(linux|windows).sh

@kezhenxu94 kezhenxu94 added the plugin Plugin label Nov 25, 2020
@kezhenxu94
Copy link
Member

@fuhuo thanks for contributing, can you please fix the CI and check the item list in the?

@fuhuo
Copy link
Contributor Author

fuhuo commented Nov 25, 2020

ok, i'll try

@kezhenxu94
Copy link
Member

ok, i'll try

If you need any help, feel free to ping me

@kezhenxu94
Copy link
Member

Please check this one by one before we can merge this PR, thanks, if you need help, feel free to ping me anytime

image

fuhuo added a commit to fuhuo/skywalking that referenced this pull request Nov 25, 2020
wu-sheng pushed a commit to apache/skywalking that referenced this pull request Nov 26, 2020
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you please also update the plugin list here, thanks very much

@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Nov 26, 2020
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your contributions and patience

@kezhenxu94 kezhenxu94 merged commit b5740d5 into apache:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants