Fix unexpected 'decode' AttributeError when MySQLdb module is mapped by PyMySQL #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some use cases, `pymysql.install_as_MySQLdb()` will be used to initialize a 'fake' MySQLdb module, which is actually mapped to pymysql module. Then the sw_mysqlclient plugin will change the data type of `connection.db` from bytes into str, cause the `AttributeError: 'str' object has no attribute 'decode'` exception in sw_pymysql.py line 45, which regard it as bytes.
|
Please fix CI. |
double quotes to single quotes
|
And you should follow PR template to |
|
@kezhenxu94 Please take a look. We also have some CIs fail, but should be irrelevant. We may need some fixes first. |
|
Ok I will take a look thanks |
|
I will temporariy disable the uwsgi case, I believe that uwsgi is getting less attraction and support will be dropped sooner or later. |
|
LGTM, let's wait for CI. |
|
Gonna kick off a release soon this weekend. |
wu-sheng
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some use cases,
pymysql.install_as_MySQLdb()will be used to initialize a 'fake' MySQLdb module, which is actually mapped to pymysql module.Unfortunately, sw_mysqlclient plugin changes the data type of
connection.dbfrombytesintostr, which is regard asbytesin sw_pymysql plugin. That will cause theAttributeError: 'str' object has no attribute 'decode'exception in sw_pymysql.py line 45.So if the
MySQLdbmodule is only a pointer topymysql, we should just raise ImportError instead of installation for sw_mysqlclient plugin.CHANGELOG.md.