Skip to content

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Sep 5, 2022

  1. The pecl package need to call these steps:

    phpize
    ./configure
    make
    make install

    So add config.m4 for phpize.

  2. The package.xml is the pecl package definition file, the <date> and <notes> should be changed before release.

@jmjoy jmjoy added this to the 0.1.0 milestone Sep 5, 2022
@jmjoy jmjoy added the enhancement New feature or request label Sep 5, 2022
@heyanlong
Copy link
Member

PECL package should from GitHub Action Artifacts (tag only). After the CI I will upload it to PECL website and send release note to PECL developers list

@jmjoy jmjoy marked this pull request as ready for review September 6, 2022 05:54
@jmjoy
Copy link
Member Author

jmjoy commented Sep 6, 2022

The pecl support is ready, the documents change will be added in next PRs.

@jmjoy jmjoy requested a review from heyanlong September 6, 2022 05:55
@heyanlong
Copy link
Member

No artifacts output?

@jmjoy
Copy link
Member Author

jmjoy commented Sep 6, 2022

What artifacts?

@heyanlong
Copy link
Member

@jmjoy
Copy link
Member Author

jmjoy commented Sep 6, 2022

I just add tests, artifacts should be generate for tag event?

@heyanlong
Copy link
Member

Yes, following tag event.

@jmjoy
Copy link
Member Author

jmjoy commented Sep 6, 2022

Add tag event in future?

@heyanlong
Copy link
Member

Can also

@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2022

What do we discuss here? Do you try to build nightly build or build per commit?

@jmjoy
Copy link
Member Author

jmjoy commented Sep 6, 2022

What do we discuss here? Do you try to build nightly build or build per commit?

I prefer to build artifacts from CI by tag event, no nightly build.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2022

The issue would be how should we call that. The RC binary should be built and signed by release manager manually, that is ASF release policy.

@jmjoy
Copy link
Member Author

jmjoy commented Sep 6, 2022

The issue would be how should we call that. The RC binary should be built and signed by release manager manually, that is ASF release policy.

Yes, maybe it's not necessary to build artifacts by tag event, or only build the package, not the sign. The signed and later operations must be handle manually.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 6, 2022

The issue would be how should we call that. The RC binary should be built and signed by release manager manually, that is ASF release policy.

Yes, maybe it's not necessary to build artifacts by tag event, or only build the package, not the sign. The signed and later operations must be handle manually.

This is not very good practice. Maybe acceptable only? Because you should only sign a thing built manually rather than from a 3rd party. Such as one day, if GitHub mixed some things as CI is not a hard-protected env(or may be hacked), then we signed and released a totally unexpected binary.

@jmjoy
Copy link
Member Author

jmjoy commented Sep 6, 2022

The issue would be how should we call that. The RC binary should be built and signed by release manager manually, that is ASF release policy.

Yes, maybe it's not necessary to build artifacts by tag event, or only build the package, not the sign. The signed and later operations must be handle manually.

This is not very good practice. Maybe acceptable only? Because you should only sign a thing built manually rather than from a 3rd party. Such as one day, if GitHub mixed some things as CI is not a hard-protected env(or may be hacked), then we signed and released a totally unexpected binary.

Alright, we will not build artifacts from CI. @heyanlong

@jmjoy jmjoy requested a review from wu-sheng September 7, 2022 08:40
@wu-sheng
Copy link
Member

wu-sheng commented Sep 7, 2022

I can see you update the scripts, but I can't find the release doc, compiling doc, and pecl install doc udpate.

@jmjoy
Copy link
Member Author

jmjoy commented Sep 7, 2022

I can see you update the scripts, but I can't find the release doc, compiling doc, and pecl install doc udpate.

I want to update the doc next PRs.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 7, 2022

BTW, you should try to set up the required CI tasks to block merging before CI passed.

@jmjoy
Copy link
Member Author

jmjoy commented Sep 7, 2022

BTW, you should try to set up the required CI tasks to block merging before CI passed.

OK, I have some doubts about this. I'll study it later.

@jmjoy jmjoy merged commit 59e6a4a into apache:master Sep 7, 2022
@jmjoy jmjoy deleted the pecl branch September 7, 2022 10:51
@jmjoy jmjoy restored the pecl branch September 7, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants