Skip to content

Conversation

heyanlong
Copy link
Member

No description provided.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 2, 2022

I think we should keep compiling doc, because, in the release process, the PMC should check your source tar is able to compile passed or not.

Also, you should have a release doc about the steps, and scripts about how to package the release source tar and binary tar(licenses of dependencies and .so files) if you would provide a binary files.

@wu-sheng wu-sheng added this to the 0.1.0 milestone Sep 2, 2022
@wu-sheng wu-sheng added the documentation Improvements or additions to documentation label Sep 2, 2022
@jmjoy
Copy link
Member

jmjoy commented Sep 2, 2022

I found pecl can install local package, so we can pack the code, and install it by pecl install skywalking_agent-0.1.0.tgz.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 2, 2022

I found pecl can install local package, so we can pack the code, and install it by pecl install skywalking_agent-0.1.0.tgz.

Would this OS sensitive?

@jmjoy
Copy link
Member

jmjoy commented Sep 2, 2022

I found pecl can install local package, so we can pack the code, and install it by pecl install skywalking_agent-0.1.0.tgz.

Would this OS sensitive?

Linux and MacOS may work well, expect Windows.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 2, 2022

That should be good, let's build the scripts for the binary. Notice, we need LICENSE for binary dependencies. Rust side should be supported by skywalking-eyes, but I don't know about PHP/C/PHPer dependencies

Copy link
Member

@jmjoy jmjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will add the pecl package support later.

@jmjoy jmjoy merged commit 4231063 into apache:master Sep 3, 2022
@wu-sheng
Copy link
Member

wu-sheng commented Sep 3, 2022

As you have added menu file, please update the website doc setting accordingly. Then we could check how PHP docs work on preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants