Skip to content

Conversation

@wu-sheng
Copy link
Member

  • Bump up apache parent pom to v35.
  • Update Maven to 3.6.3 in mvnw.
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added this to the 9.6.0 milestone Aug 21, 2025
@wu-sheng wu-sheng requested a review from Copilot August 21, 2025 09:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Apache parent POM from version 21 to version 35 and upgrades the Maven wrapper to version 3.6.3. The changes standardize Java compilation settings across the project by leveraging the parent POM's configuration and removing redundant property declarations.

  • Upgrades Apache parent POM from v21 to v35
  • Updates Maven wrapper from 3.6.1 to 3.6.3
  • Consolidates Java compiler settings and removes duplicate property declarations

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pom.xml Updates Apache parent POM version and adds standardized Java compiler properties
.mvn/wrapper/maven-wrapper.properties Updates Maven wrapper to version 3.6.3
test/plugin/scenarios/micronaut-http-scenario/pom.xml Removes redundant Java compiler properties
apm-sniffer/bootstrap-plugins/jdk-http-plugin/pom.xml Adds compiler release property override
apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/pom.xml Removes duplicate compiler source/target properties
apm-sniffer/apm-sdk-plugin/elasticsearch-5.x-plugin/pom.xml Removes duplicate Java version properties
CHANGES.md Documents the version updates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +35 to +36
<!-- Reset this to the blank value to avoid using -release in JDK compiling -->
<maven.compiler.release></maven.compiler.release>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. Refer to Maven doc,

Starting with JDK 9, the javac executable can accept the --release option to specify against which Java SE release you want to build the project. For example, you have JDK 11 installed and used by Maven, but you want to build the project against Java 8. The --release option ensures that the code is compiled following the rules of the programming language of the specified release, and that generated classes target the release as well as the public API of that release. This means that, unlike the old -source and -target options, the compiler will detect and generate an error when using APIs that don't exist in previous releases of Java SE.

@wu-sheng wu-sheng merged commit 80d3958 into main Aug 21, 2025
196 checks passed
@wu-sheng wu-sheng deleted the pom-upgrade branch August 21, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants