Docker Multiple Architecture Support (#132)

Closes apache/skywalking#9089
apache · Sep 2, 2022 · cbb6f55 · cbb6f55
1 parent 00b35e5
commit cbb6f55
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/publish-docker.yaml b/.github/workflows/publish-docker.yaml
@@ -54,6 +54,4 @@ jobs:
           password: ${{ secrets.GITHUB_TOKEN }}
       - name: Build and push docker image
         run: |
-          make docker && make docker-push
-          docker tag $HUB/license-eye:$VERSION $HUB/license-eye:latest
-          docker push $HUB/license-eye:latest
+          make docker-release
diff --git a/Makefile b/Makefile
@@ -72,15 +72,19 @@ build: windows linux darwin
 
 .PHONY: docker
 docker:
-	docker build . -t $(HUB)/$(PROJECT):$(VERSION)
+	docker build . -t $(HUB)/$(PROJECT):$(VERSION) -t $(HUB)/$(PROJECT):latest
 
 .PHONY: docker-push
 docker-push:
-	docker push $(HUB)/$(PROJECT):$(VERSION)
+	@{\
+		docker buildx create --use --driver docker-container --name skywalking_eyes_main ;\
+		docker buildx build --push --platform linux/amd64,linux/arm64 -t $(HUB)/$(PROJECT):$(VERSION) -t $(HUB)/$(PROJECT):latest . ;\
+		build_exit_code=$$? ;\
+		docker buildx rm skywalking_eyes_main ;\
+		exit $$build_exit_code;\
+	}
 
-.PHONY: docker-release
 docker-release: docker docker-push
-	docker tag $(HUB)/$(PROJECT):$(VERSION) $(HUB)/$(PROJECT):latest && docker push $(HUB)/$(PROJECT):latest
 
 .PHONY: clean
 clean: