Remove cli module from pkg module and bump to go 1.24 #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 413 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 315 | 2 | 96 | 0 |
Click to see the invalid file list
- internal/display/display.go
- pkg/contextkey/contextkey.go
kezhenxu94
force-pushed
the
refactor
branch
2 times, most recently
from
c628c1e to
1ffad08
Compare
wu-sheng
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgmodule can be used in users’ customized projects to leverage the query protocol, but now it is coupled with the cli module"github.com/urfave/cli/v2", which makes it impossible for users to use it if users are using other cli framework such as cobra cli. This PR moves the needs ofgithub.com/urfave/cliinpkgand add a depguard rule to prevent it in the future.