-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep package.json and package-lock.json in sync #154
Conversation
Maybe that's why every time I run |
It is better we could update docs here? https://github.com/apache/skywalking-booster-ui#development |
What do you want to add? |
|
I want to discuss what is recommend when we run skywalking UI/backend build. The difference would make veraions in license file not match the binary. |
You don't understand how this is fixed. This patch resolves the problem that package-lock.json doesn't lock some dependencies versions because they are missing in package-lock.json file. It also guarantees that this case won't happen again in the future by making sure the package-lock.json is in sync with package.json. When developers build/install without any changes the versions are guaranteed by the lock file so no version is changed. When developers upgrade any dependencies in local machine, they also have to make sure the two files are in sync otherwise the CI would fail. |
There is nothing changed in building the UI. Just keep everything every command the same as before. |
The package.json and package-lock.json is not in sync, this patch makes them in sync and such we can perform reliable builds using
npm ci
.