Skip to content

[SHIRO-610] Allways create resolver for non-empty IniWebEnvironment #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fpapon merged 1 commit into from
Jul 22, 2020
Merged

[SHIRO-610] Allways create resolver for non-empty IniWebEnvironment #242

fpapon merged 1 commit into from
Jul 22, 2020

Conversation

@tbrugz
Copy link
Contributor

@tbrugz tbrugz commented Jun 19, 2020

@fpapon fpapon self-requested a review June 19, 2020 14:27
@tbrugz tbrugz mentioned this pull request Jun 19, 2020
Closed
1 task
bmarwell
bmarwell requested changes Jun 25, 2020
View reviewed changes
@tbrugz
Copy link
Contributor Author

tbrugz commented Jul 15, 2020

@fpapon @bmhm Let me know if I should add something else to the PR

fpapon
fpapon approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpapon fpapon requested a review from bmarwell July 15, 2020 19:58
@fpapon
Copy link
Member

fpapon commented Jul 21, 2020

@bmhm can you review please?

@fpapon fpapon merged commit 6c4e8f1 into apache:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmarwell bmarwell bmarwell approved these changes

@fpapon fpapon fpapon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbrugz @fpapon @bmarwell