[#SHIRO-875] Fix creating subjects from a SubjectFactory that disables session-creation
#1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lprimak
approved these changes
Jun 2, 2024
bdemers
requested changes
Jun 3, 2024
Member
bdemers
left a comment
bdemers
left a comment
There was a problem hiding this comment.
This change looks good, but the test doesn't look like it's asserting that no session is being created? Can the test be improved (or commented if i'm reading it wrong)
Contributor
Author
|
@bdemers thanks for the feedback! The test is pretty much the same as the one above it - it doesn't do anything with the session on its own but the |
fpapon
approved these changes
Jun 3, 2024
Member
fpapon
left a comment
fpapon
left a comment
There was a problem hiding this comment.
@boris-petrov thanks for your contribution!
boris-petrov
deleted the
fix-creating-subjects-with-special-subject-factory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I had to remove the PR template after I've read it and made sure I followed everything in it. Perhaps you might want to note that in it.
This continues the work done in #1407. I didn't think of that case in it so this PR fixes it. I didn't open a new issue for it, sorry, I guess we could reuse the old one as it's a similar case.
cc @lprimak