Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Upgrade Shiro to htmlunit 3.3.0 or higher #1010

Closed
2 tasks done
lprimak opened this issue Jul 14, 2023 · 2 comments · Fixed by #1035
Closed
2 tasks done

[Enhancement] Upgrade Shiro to htmlunit 3.3.0 or higher #1010

lprimak opened this issue Jul 14, 2023 · 2 comments · Fixed by #1035
Assignees
@lprimak
Labels
dependencies Pull requests that update a dependency file good-first-issue Good First Issue help-wanted Help Wanted
Milestone
2.0

Comments

@lprimak
Copy link
Contributor

lprimak commented Jul 14, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

HtmlUnit 2.x is EOL.
Need to update to HtmlUnit 3.x as described below:
https://github.com/HtmlUnit/htmlunit/releases/tag/3.3.0

Describe the solution you'd like

Self-expanatory

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@lprimak lprimak added good-first-issue Good First Issue help-wanted Help Wanted labels Jul 14, 2023
@lprimak lprimak mentioned this issue Jul 14, 2023
Closed
@bmarwell
Copy link
Contributor

If it was not so much work, I'd say use JSoup... but that may be for another day.

@lprimak
Copy link
Contributor Author

lprimak commented Jul 20, 2023

Seems simple just to upgrade, but I am not opposed to jsoup either

@lprimak lprimak added the dependencies Pull requests that update a dependency file label Jul 29, 2023
@lprimak lprimak added this to the 2.0 milestone Aug 20, 2023
@lprimak lprimak self-assigned this Aug 20, 2023
@lprimak lprimak mentioned this issue Aug 20, 2023
Merged
10 tasks
lprimak added a commit that referenced this issue Aug 20, 2023
@lprimak
Merge pull request #1035 from lprimak/upgrade-htmlunit
106c9ca 
[#1010] deps: updated htmlunit to 3.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lprimak lprimak

Labels
dependencies Pull requests that update a dependency file good-first-issue Good First Issue help-wanted Help Wanted
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

[#1010] deps: updated htmlunit to 3.5.0 lprimak/shiro
2 participants
@lprimak @bmarwell