fix: avoid NPE when selector/rule sync data is null (#6890) - #6925
Open
juicewcode wants to merge 1 commit into
Open
fix: avoid NPE when selector/rule sync data is null (#6890)#6925juicewcode wants to merge 1 commit into
juicewcode wants to merge 1 commit into
Conversation
When the http sync data is null, CollectionUtils.isEmpty(null) is true and the original code called data.forEach (pluginDataSubscriber::unSelectorSubscribe), which threw a NullPointerException. The forEach on the empty/null data was dead code in the empty-list case and the NPE trigger in the null case. Restructure refresh() to clear the cache unconditionally first, following the same implementation as PluginDataRefresh, and return early when the data is empty, so a null payload clears the cache instead of crashing. Behavior for empty and non-empty data is unchanged. Add regression tests covering refresh with null data for both refreshers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6890
summary
PluginDataRefresh, and return early when the data is empty, so a null payload clears the cache instead of crashing. Behavior for empty and non-empty data is unchanged.Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.