Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for ShenyuClientRegisterEventPublisher #5417

Conversation

Divyansh200102
Copy link
Contributor

@Divyansh200102 Divyansh200102 commented Jan 23, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@Divyansh200102 Divyansh200102 marked this pull request as draft January 23, 2024 17:40
@Divyansh200102
Copy link
Contributor Author

Divyansh200102 commented Jan 23, 2024

@dragon-zhang @moremind I have no idea why the checks are failing the tests are working fine in my local system please help me resolve this.
image

@moremind
Copy link
Member

looks good, but you should add public for the test method and check the code

@moremind moremind marked this pull request as ready for review January 24, 2024 01:30
@Divyansh200102
Copy link
Contributor Author

looks good, but you should add public for the test method and check the code

I did as said but still it's not working @moremind .I am not able to figure out what's going wrong?

@moremind
Copy link
Member

moremind commented Jan 24, 2024

Error:  src/main/java/org/apache/shenyu/client/core/disruptor/ShenyuClientRegisterEventPublisher.java:[60] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous statement.
Error:  src/main/java/org/apache/shenyu/client/core/disruptor/ShenyuClientRegisterEventPublisher.java:[60,5] (javadoc) JavadocMethod: Missing a Javadoc comment.
Error:  src/main/java/org/apache/shenyu/client/core/disruptor/ShenyuClientRegisterEventPublisher.java:[68] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous statement.
Error:  src/test/java/org/apache/shenyu/client/core/disruptor/subcriber/ShenyuClientRegisterEventPublisherTest.java:[33] (whitespace) EmptyLineSeparator: 'VARIABLE_DEF' should be separated from previous statement.

@Divyansh200102
Copy link
Contributor Author

Divyansh200102 commented Jan 24, 2024

Error:  src/main/java/org/apache/shenyu/client/core/disruptor/ShenyuClientRegisterEventPublisher.java:[60] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous statement.
Error:  src/main/java/org/apache/shenyu/client/core/disruptor/ShenyuClientRegisterEventPublisher.java:[60,5] (javadoc) JavadocMethod: Missing a Javadoc comment.
Error:  src/main/java/org/apache/shenyu/client/core/disruptor/ShenyuClientRegisterEventPublisher.java:[68] (whitespace) EmptyLineSeparator: 'METHOD_DEF' should be separated from previous statement.
Error:  src/test/java/org/apache/shenyu/client/core/disruptor/subcriber/ShenyuClientRegisterEventPublisherTest.java:[33] (whitespace) EmptyLineSeparator: 'VARIABLE_DEF' should be separated from previous statement.

Could you please tell how do i resolve the remaining checks ? @moremind

@moremind moremind added this to the 2.6.2 milestone Jan 24, 2024
@moremind moremind merged commit b17d480 into apache:master Jan 24, 2024
50 checks passed
@Divyansh200102 Divyansh200102 deleted the Add-test-case-for-ShenyuClientRegisterEventPublisher branch January 24, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants