Sofa test #512
Merged
Sofa test #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
============================================
- Coverage 15.08% 14.98% -0.11%
- Complexity 115 294 +179
============================================
Files 124 251 +127
Lines 2340 5172 +2832
Branches 274 489 +215
============================================
+ Hits 353 775 +422
- Misses 1927 4305 +2378
- Partials 60 92 +32
Continue to review full report at Codecov.
|
yu199195
reviewed
Dec 4, 2020
| <groupId>io.projectreactor</groupId> | ||
| <artifactId>reactor-test</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| </project> |
| * @author tydhot | ||
| */ | ||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class SofaPluginTest { |
| SelectorData selectorData = mock(SelectorData.class); | ||
| StepVerifier.create(sofaPlugin.doExecute(exchange, chain, selectorData, data)).expectSubscription().verifyComplete(); | ||
| } | ||
|
|
| * @author tydhot | ||
| */ | ||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class SofaPluginDataHandlerTest { |
| sofaPluginDataHandler.handlerPlugin(pluginData); | ||
| Assert.assertNull(Singleton.INST.get(SofaRegisterConfig.class)); | ||
| } | ||
|
|
| formExchange.getAttributes().put(Constants.CONTEXT, context); | ||
| StepVerifier.create(bodyParamPlugin.execute(formExchange, chain)).expectSubscription().verifyComplete(); | ||
| } | ||
|
|
| import reactor.core.publisher.Mono; | ||
| import reactor.test.StepVerifier; | ||
|
|
||
|
|
| Mockito.when(chain.execute(exchange)).thenReturn(Mono.empty()); | ||
| sofaResponsePlugin = new SofaResponsePlugin(); | ||
| exchange.getAttributes().put(Constants.SOFA_RPC_RESULT, response); | ||
|
|
|
|
||
| StepVerifier.create(sofaResponsePlugin.execute(exchange, chain)).expectSubscription().verifyError(NullPointerException.class); | ||
| } | ||
|
|
| } | ||
|
|
||
| @Test(expected = SofaRpcRuntimeException.class) | ||
| public void test01OnSubscribe() { |
yu199195
approved these changes
Dec 4, 2020
|
Whether the test needs to be standardized？ We can divide it into functions, logic, and scenarios. What do you think? I think this can be used as a judgment at the time of review. can improve code quality. @yu199195 @dengliming |
we should in other issue discuss the question |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn clean install -Dmaven.javadoc.skip=true.