Skip to content

[ type:feature] Support shenyu-sdk-client by openFeign#5041

Merged
moremind merged 35 commits into
apache:masterfrom
damonxue:sdk_springcloud_1
Aug 24, 2023
Merged

[ type:feature] Support shenyu-sdk-client by openFeign#5041
moremind merged 35 commits into
apache:masterfrom
damonxue:sdk_springcloud_1

Conversation

@damonxue

@damonxue damonxue commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Support shenyu-sdk-client by openFeign.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

sdk_springcloud merged
@damonxue damonxue closed this Aug 17, 2023
@damonxue damonxue reopened this Aug 17, 2023
@codecov-commenter

codecov-commenter commented Aug 17, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.11321% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.14%. Comparing base (6d341fd) to head (42e03fa).
⚠️ Report is 535 commits behind head on master.

Files with missing lines Patch % Lines
...pache/shenyu/sdk/feign/ShenyuClientsRegistrar.java 59.22% 44 Missing and 40 partials ⚠️
...apache/shenyu/sdk/feign/ShenyuDiscoveryClient.java 50.00% 11 Missing and 5 partials ⚠️
...org/apache/shenyu/common/enums/HttpSchemeEnum.java 0.00% 7 Missing ⚠️
...pache/shenyu/sdk/feign/ShenyuClientCapability.java 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5041      +/-   ##
============================================
- Coverage     63.17%   63.14%   -0.04%     
- Complexity     8517     8560      +43     
============================================
  Files          1221     1225       +4     
  Lines         36367    36632     +265     
  Branches       3328     3379      +51     
============================================
+ Hits          22974    23130     +156     
- Misses        11503    11565      +62     
- Partials       1890     1937      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@damonxue

Copy link
Copy Markdown
Contributor Author

@yunlongn pls review.

@damonxue damonxue closed this Aug 18, 2023
@damonxue damonxue reopened this Aug 18, 2023
@damonxue

Copy link
Copy Markdown
Contributor Author

@yunlongn @moremind pls review.

moremind
moremind previously approved these changes Aug 18, 2023
@moremind moremind requested a review from yunlongn August 19, 2023 03:51
yunlongn
yunlongn previously approved these changes Aug 21, 2023
@damonxue damonxue closed this Aug 22, 2023
@damonxue damonxue reopened this Aug 22, 2023
@damonxue damonxue closed this Aug 22, 2023
@damonxue damonxue reopened this Aug 22, 2023
@damonxue damonxue closed this Aug 22, 2023
@damonxue damonxue reopened this Aug 22, 2023
@damonxue damonxue closed this Aug 23, 2023
@damonxue damonxue reopened this Aug 23, 2023
@damonxue damonxue closed this Aug 23, 2023
@damonxue damonxue reopened this Aug 23, 2023
moremind
moremind previously approved these changes Aug 24, 2023
yunlongn
yunlongn previously approved these changes Aug 24, 2023
@damonxue damonxue dismissed stale reviews from yunlongn and moremind via cbf3daa August 24, 2023 01:44
moremind
moremind previously approved these changes Aug 24, 2023
@moremind moremind merged commit 8c41641 into apache:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants