Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3680] Add shenyu-client-http-springmvc unit test #3681

Merged

Conversation

847850277
Copy link
Contributor

Hi, community
I have finished unit test "shenyu-client-http-springmvc".
see Issues #3680
please review code.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #3681 (9cbdf6c) into master (59e7a95) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3681      +/-   ##
============================================
- Coverage     62.96%   62.83%   -0.13%     
- Complexity     5878     5889      +11     
============================================
  Files           902      904       +2     
  Lines         24609    24743     +134     
  Branches       2229     2252      +23     
============================================
+ Hits          15494    15547      +53     
- Misses         7715     7789      +74     
- Partials       1400     1407       +7     
Impacted Files Coverage Δ
...client/springmvc/init/ContextRegisterListener.java 0.00% <0.00%> (ø)
...t/springmvc/init/SpringMvcClientEventListener.java 59.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e7a95...9cbdf6c. Read the comment docs.

@loongs-zhang
Copy link
Member

I will review it later.

@loongs-zhang
Copy link
Member

@847850277 have fun with contribution !

@loongs-zhang loongs-zhang merged commit d6f194d into apache:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants