Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for nacos register center client #1220

Merged
merged 1 commit into from
Apr 5, 2021
Merged

add test for nacos register center client #1220

merged 1 commit into from
Apr 5, 2021

Conversation

freedom-xiao007
Copy link
Contributor

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

@codecov-io
Copy link

codecov-io commented Apr 4, 2021

Codecov Report

Merging #1220 (8a5d9f0) into master (a99c9fc) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1220      +/-   ##
============================================
+ Coverage     70.33%   70.36%   +0.03%     
- Complexity     2088     2093       +5     
============================================
  Files           375      376       +1     
  Lines          8278     8322      +44     
  Branches        902      903       +1     
============================================
+ Hits           5822     5856      +34     
- Misses         2014     2018       +4     
- Partials        442      448       +6     
Impacted Files Coverage Δ Complexity Δ
...er/client/nacos/NacosClientRegisterRepository.java 70.45% <0.00%> (ø) 5.00% <0.00%> (?%)
...omara/soul/sync/data/http/HttpSyncDataService.java 75.49% <0.00%> (+2.94%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99c9fc...8a5d9f0. Read the comment docs.

@yu199195 yu199195 merged commit 000e54d into apache:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants