Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue1212 #1213

Merged
merged 3 commits into from
Apr 1, 2021
Merged

fix issue1212 #1213

merged 3 commits into from
Apr 1, 2021

Conversation

leohou0430
Copy link
Contributor

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

@leohou0430 leohou0430 closed this Mar 31, 2021
@leohou0430 leohou0430 reopened this Mar 31, 2021
@yu199195
Copy link
Member

yu199195 commented Apr 1, 2021

please check ci

@codecov-io
Copy link

codecov-io commented Apr 1, 2021

Codecov Report

Merging #1213 (df619b2) into master (15092ee) will decrease coverage by 0.72%.
The diff coverage is 21.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1213      +/-   ##
============================================
- Coverage     70.62%   69.90%   -0.73%     
+ Complexity     2087     2083       -4     
============================================
  Files           372      374       +2     
  Lines          8239     8276      +37     
  Branches        899      903       +4     
============================================
- Hits           5819     5785      -34     
- Misses         1977     2048      +71     
  Partials        443      443              
Impacted Files Coverage Δ Complexity Δ
.../sync/data/websocket/WebsocketSyncDataService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ul/admin/listener/websocket/WebsocketListener.java 10.00% <10.00%> (ø) 2.00 <2.00> (?)
...dmin/listener/websocket/WebsocketConfigurator.java 33.33% <33.33%> (ø) 2.00 <2.00> (?)
...l/admin/listener/websocket/WebsocketCollector.java 76.92% <50.00%> (-10.18%) 12.00 <2.00> (+1.00) ⬇️
...soul/client/tars/TarsServiceBeanPostProcessor.java 23.17% <0.00%> (-59.76%) 5.00% <0.00%> (-9.00%)
.../soul/plugin/httpclient/NettyHttpClientPlugin.java 57.14% <0.00%> (-2.05%) 10.00% <0.00%> (ø%)
...omara/soul/sync/data/http/HttpSyncDataService.java 72.54% <0.00%> (+8.82%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15092ee...df619b2. Read the comment docs.

@dengliming dengliming added this to the 2.3.0 milestone Apr 1, 2021
@yu199195 yu199195 merged commit f36fedb into apache:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix websocket sync data java.io.EOFException and update websocket log support show client ip
4 participants