Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test case for SpringCloudPluginConfiguration. #1073

Merged
merged 1 commit into from
Jan 29, 2021
Merged

test: Add test case for SpringCloudPluginConfiguration. #1073

merged 1 commit into from
Jan 29, 2021

Conversation

Asxing
Copy link
Member

@Asxing Asxing commented Jan 29, 2021

test: Add test case for SpringCloudPluginConfiguration.

#878

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

@yu199195 yu199195 added this to the 2.3.0 milestone Jan 29, 2021
@codecov-io
Copy link

Codecov Report

Merging #1073 (bd31406) into master (56ed5ef) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1073      +/-   ##
============================================
- Coverage     75.25%   74.94%   -0.32%     
+ Complexity     2140     2133       -7     
============================================
  Files           365      366       +1     
  Lines          8080     8082       +2     
  Branches        884      884              
============================================
- Hits           6081     6057      -24     
- Misses         1535     1559      +24     
- Partials        464      466       +2     
Impacted Files Coverage Δ Complexity Δ
...omara/soul/sync/data/http/HttpSyncDataService.java 49.01% <0.00%> (-16.67%) 10.00% <0.00%> (-2.00%)
...oul/sync/data/http/refresh/DataRefreshFactory.java 91.66% <0.00%> (-8.34%) 4.00% <0.00%> (-1.00%)
...che/dubbo/ApacheDubboServiceBeanPostProcessor.java 79.10% <0.00%> (-4.48%) 11.00% <0.00%> (-2.00%)
...ba/dubbo/AlibabaDubboServiceBeanPostProcessor.java 79.10% <0.00%> (-4.48%) 11.00% <0.00%> (-2.00%)
.../soul/admin/service/impl/UpstreamCheckService.java 75.38% <0.00%> (-1.54%) 14.00% <0.00%> (-1.00%)
...soul/plugin/tars/cache/ApplicationConfigCache.java 81.94% <0.00%> (-1.39%) 12.00% <0.00%> (-1.00%)
...in/springcloud/SpringCloudPluginConfiguration.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce242e0...bd31406. Read the comment docs.

@yu199195 yu199195 merged commit 133ff1b into apache:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants