[BUG] ShenYu-admin 2.5.0 docker image not work with mysql jdbc drive error

[jbh2507]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Can't find JDBC driver! ShenYu admin is not deployed

Expected Behavior

just run docker with mysql

Steps To Reproduce

1. use docker image 2.5.0

docker run -v /${some_dir}/ext-lib:/opt/shenyu-admin/ext-lib -e "SPRING_PROFILES_ACTIVE=mysql" -e "spring.datasource.url=jdbc:mysql://${your_ip_port}/shenyu?useUnicode=true&characterEncoding=utf-8&useSSL=false&serverTimezone=Asia/Shanghai&zeroDateTimeBehavior=convertToNull" -e "spring.datasource.username=${your_username}" -e "spring.datasource.password=${your_password}" -d -p 9095:9095 --net shenyu apache/shenyu-admin:2.5.0

Environment

ShenYu version(s):2.5.0
Docker version: 20.10.17

Debug logs

Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2022-09-01 19:35:36 [main] ERROR org.springframework.boot.SpringApplication - Application run failed
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'dataPermissionAspect' defined in URL [jar:file:/opt/shenyu-bootstrap/lib/shenyu-admin-2.5.0.jar!/org/apache/shenyu/admin/aspect/DataPermissionAspect.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'dataPermissionServiceImpl' defined in URL [jar:file:/opt/shenyu-bootstrap/lib/shenyu-admin-2.5.0.jar!/org/apache/shenyu/admin/service/impl/DataPermissionServiceImpl.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataPermissionMapper' defined in URL [jar:file:/opt/shenyu-bootstrap/lib/shenyu-admin-2.5.0.jar!/org/apache/shenyu/admin/mapper/DataPermissionMapper.class]: Cannot resolve reference to bean 'sqlSessionTemplate' while setting bean property 'sqlSessionTemplate'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'sqlSessionTemplate' defined in class path resource [org/mybatis/spring/boot/autoconfigure/MybatisAutoConfiguration.class]: Unsatisfied dependency expressed through method 'sqlSessionTemplate' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'sqlSessionFactory' defined in class path resource [org/mybatis/spring/boot/autoconfigure/MybatisAutoConfiguration.class]: Unsatisfied dependency expressed through method 'sqlSessionFactory' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataSource' defined in class path resource [org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration$Hikari.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.zaxxer.hikari.HikariDataSource]: Factory method 'dataSource' threw exception; nested exception is java.lang.IllegalStateException: Cannot load driver class: com.mysql.cj.jdbc.Driver
	at org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:800)
	at org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:229)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1372)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1222)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:582)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:953)
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:145)
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:745)
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:420)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:307)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1317)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1306)
	at org.apache.shenyu.admin.ShenyuAdminBootstrap.main(ShenyuAdminBootstrap.java:36)


....


Caused by: java.lang.IllegalStateException: Cannot load driver class: com.mysql.cj.jdbc.Driver
	at org.springframework.util.Assert.state(Assert.java:97)
	at org.springframework.boot.autoconfigure.jdbc.DataSourceProperties.determineDriverClassName(DataSourceProperties.java:241)
	at org.springframework.boot.autoconfigure.jdbc.DataSourceProperties.initializeDataSourceBuilder(DataSourceProperties.java:193)
	at org.springframework.boot.autoconfigure.jdbc.DataSourceConfiguration.createDataSource(DataSourceConfiguration.java:48)
	at org.springframework.boot.autoconfigure.jdbc.DataSourceConfiguration$Hikari.dataSource(DataSourceConfiguration.java:90)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154)
	... 86 common frames omitted
[shenyu-admin-error.log](https://github.com/apache/shenyu/files/9469139/shenyu-admin-error.log)

Anything else?

It is probably because of the following contents of line 17 of the docker file.

'WORKDIR /opt/shenyu-bootstrap' -> 'WORKDIR /opt/shenyu-admin'

[yu199195]

can you copy mysql-connector.jar to /$(your_work_dir)/ext-lib？

[jbh2507]

Yes, I did. I also checked that the jar file exists in the '/opt/shenyu-admin/ext-lib' path using the 'docker exec' command.

[jbh2507]

If I change the docker volume mount to '/opt/shenyu-bootstrap/ext-lib' and run it, the dirver not found error goes away (although it still fails with other errors)

[jilliss]

If I change the docker volume mount to '/opt/shenyu-bootstrap/ext-lib' and run it, the dirver not found error goes away (although it still fails with other errors)

After a brief test, first of all, my environment is the image of mysql:8 running by Docker and I added this image to Shenyu network （--net shenyu）

I then mounted the mysql JDBC driver JAR package into the opt/shenyu-bootstrap/ext-lib directory

When I started the apache/shenyu-admin:2.5.0 image, I made the following changes to my JDBC URL

jdbc:mysql://shenyu-mysql:3306/shenyu?useUnicode=true&characterEncoding=utf-8&useSSL=false&allowPublicKeyRetrieval=true&serverTimezone=Asia/Shanghai&zeroDateTimeBeh
avior=convertToNull

Everything is working fine
ps shenyu-mysql is the name I gave to the mysql container

[yu199195]

@jilliss

maybe add to opt/shenyu-admin/ext-lib? only shenyu-admin used mysql.

I then mounted the mysql JDBC driver JAR package into the opt/shenyu-bootstrap/ext-lib directory

[jilliss]

However, I think this is still a problem, either the documentation is wrong, or the packaging image is wrong

2022-09-02 07:34:43 [main] INFO  org.apache.shenyu.admin.ShenyuAdminBootstrap - Starting ShenyuAdminBootstrap v2.5.0 using Java 1.8.0_212 on b7d3ed31f336 with PID 37 (/opt/shenyu-bootstrap/lib/shenyu-admin-2.5.0.jar started by root in /opt/shenyu-bootstrap)

@jilliss

maybe add to opt/shenyu-admin/ext-lib? only shenyu-admin used mysql.

I then mounted the mysql JDBC driver JAR package into the opt/shenyu-bootstrap/ext-lib directory

[jilliss]

@jilliss

maybe add to opt/shenyu-admin/ext-lib? only shenyu-admin used mysql.

I then mounted the mysql JDBC driver JAR package into the opt/shenyu-bootstrap/ext-lib directory

The log shows that the admin container is running in /opt/shenyu-bootstrap/ This is an obvious problem. If I do not mount the /opt/shenyu-admin/ext-lib container, the /opt/shenyu-admin directory will not appear

[yu199195]

@jilliss hi，shenyu-admin ,shenyu-boostrap are 2 different applications and should have 2 different directories

shenyu-admin: you can see this : https://github.com/apache/shenyu/blob/master/shenyu-dist/shenyu-admin-dist/Dockerfile
shenyu-boostrap , see this: https://github.com/apache/shenyu/blob/master/shenyu-dist/shenyu-bootstrap-dist/Dockerfile

[jilliss]

@yu199195
Yes, I know very well that there should be a problem when packing your Docker image. This is the LAYERS of Shenyu-admin :2.5.0 image that I queried on Docker Hub
Its WORKDIR should be shenyu-admin, right

[jilliss]

The problem now is that Docker Image version 2.5.0 must be mounted to /opt/shenyu-boostrap/ext-lib in order to work properly. I suggest you repackage the Docker Image

[jbh2507]

The problem now is that Docker Image version 2.5.0 must be mounted to /opt/shenyu-boostrap/ext-lib in order to work properly. I suggest you repackage the Docker Image

I mentioned it in the first comment of issue, but it doesn't seem to be recognized properly due to a markdown mistake. (I forgot to close the code block in Debug logs step correctly) Thanks for checking.

[impactCn]

@jbh2507 Updated docker bug above. You can go to docker hub again to pull it.