Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributor doc for update release note when submit new pr #33049

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Update contributor doc for update release note when submit new pr #33049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@

### Enhancement

1. SQL Parser: Support PostgreSQL, openGauss function table and update from segment parse - #32994
1. SQL Parser: Support PostgreSQL, openGauss function table and update from segment parse - [#32994](https://github.com/apache/shardingsphere/pull/32994)

### Bug Fix

1. Sharding: Fix alter view exception when config sharding rule and binding table rule - #32696
1. Sharding: Fix alter view exception when config sharding rule and binding table rule - [#32696](https://github.com/apache/shardingsphere/issues/32696)

### Change Log

Expand Down
6 changes: 5 additions & 1 deletion docs/community/content/involved/contribute/contributor.cn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,11 @@ git push origin issueNo
- 接着导师做 CodeReview，然后他会与您讨论一些细节（包括设计，实现，性能等）。当导师对本次修改满意后，会将提交合并到当前开发版本的分支中。
- 最后，恭喜您已经成为了 ShardingSphere 的官方贡献者！

**6. 删除分支**
**6. 更新 Release Note**

- 编码完成后，请更新当前开发版本的 [Release Note](https://github.com/apache/shardingsphere/blob/master/RELEASE-NOTES.md)，根据 issue 的不同类型，在 `API Change`、`New Feature`、`Enhancement` 或 `Bug Fix` 分类中进行添加，`RELEASE-NOTES` 需要遵循统一的格式：`{feature_name}: {description} - {issue/pr link}`，例如：`SQL Parser: Support PostgreSQL, openGauss function table and update from segment parse - #32994`。

**7. 删除分支**

- 在导师将 pull request 合并到 ShardingSphere 的 master 分支中之后，您就可以将远程的分支（origin/issueNo）及与远程分支（origin/issueNo）关联的本地分支（issueNo）删除。

Expand Down
6 changes: 5 additions & 1 deletion docs/community/content/involved/contribute/contributor.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,11 @@ git push origin issueNo
- The mentor will do code review before discussing some details (including the design, the implementation and the performance) with you. The request will be merged into the branch of current development version after the edit is well enough.
- At last, congratulations on being an official contributor of ShardingSphere

**6. Delete Branch**
**6. Update Release Note**

- After coding is completed, please update the [Release Note](https://github.com/apache/shardingsphere/blob/master/RELEASE-NOTES.md) of current development version. According to the different types of issues, add them in the `API Change`, `New Feature`, `Enhancement` or `Bug Fix` categories. `RELEASE-NOTES` needs to follow the unified format: `{feature_name}: {description} - {issue/pr link}`, for example: `SQL Parser: Support PostgreSQL, openGauss function table and update from segment parse - #32994`.

**7. Delete Branch**

- You can delete the remote branch (origin/issueNo) and the local branch (issueNo) associated with the remote branch (origin/issueNo) after the mentor merged the pull request into the master branch of ShardingSphere.

Expand Down