Add GraalVM Reachability Metadata and corresponding nativeTest for ClickHouse integration over http#31451
Merged
RaigorJiang merged 1 commit intoapache:masterfrom May 31, 2024
Conversation
3d37706 to
96c67de
Compare
67c2873 to
f274d5d
Compare
f274d5d to
79548f1
Compare
…ickHouse integration over http
79548f1 to
7554413
Compare
RaigorJiang
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
org.apache.shardingsphere.infra.database.core.connector.ConnectionPropertiesParserorg.apache.shardingsphere.infra.database.core.metadata.database.DialectDatabaseMetaDataorg.apache.shardingsphere.infra.database.clickhouse.type.ClickHouseDatabaseTypefrom continuing to use the MySQL dialect.org.testcontainers:clickhouseusing the outdatedyandex/clickhouse-serverDocker Image, a temporary classorg.apache.shardingsphere.test.natived.jdbc.commons.testcontainers.ClickHouseProvideris introduced to use Stringshardingsphere0clickhouseas thedatabaseTypeof testcontainers-java. Refer to [Enhancement]:org.testcontainers.containers.ClickHouseProvidershould useclickhouse/clickhouse-serveras Docker Image testcontainers/testcontainers-java#8736 .org.apache.shardingsphere:shardingsphere-parser-sql-clickhouseis actually an optional module, update documentation.org.apache.shardingsphere:shardingsphere-parser-sql-clickhousewith TODO.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.