Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typo in CONTRIBUTING.md #28766

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fixed typo in CONTRIBUTING.md #28766

merged 1 commit into from
Oct 16, 2023

Conversation

AbhineshJha
Copy link
Contributor

@AbhineshJha AbhineshJha commented Oct 15, 2023 •
edited
Loading

some grammar and punctuation mistakes

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

strongduanmu
strongduanmu approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbhineshJha Thank you for your work.

@strongduanmu strongduanmu merged commit 21cfb95 into apache:master Oct 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
in: document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhineshJha @strongduanmu