Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for YamlTableDataConsistencyCheckResultSwapper #28735

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Add unit test for YamlTableDataConsistencyCheckResultSwapper #28735

merged 2 commits into from
Oct 15, 2023

Conversation

pavanbaloju
Copy link
Contributor

@pavanbaloju pavanbaloju commented Oct 12, 2023 •
edited
Loading

Fixes #28540 .

Changes proposed in this pull request:

  • Added unit test for YamlTableDataConsistencyCheckResultSwapper with 100% coverage

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@zhaojinchao95 zhaojinchao95 added this to the 5.4.2 milestone Oct 13, 2023
@pavanbaloju
Copy link
Contributor Author

@zhaojinchao95 can we merge this ?

@sandynz sandynz merged commit 5097571 into apache:master Oct 15, 2023
15 checks passed
@sandynz
Copy link
Contributor

sandynz commented Oct 15, 2023

@pavanbaloju Thanks for your contribution.

@pavanbaloju pavanbaloju deleted the add-unit-test-YamlTableDataConsistencyCheckResultSwapper branch October 15, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandynz sandynz sandynz approved these changes

Assignees
No one assigned
Labels
in: test
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add unit test for YamlTableDataConsistencyCheckResultSwapper
3 participants
@pavanbaloju @sandynz @zhaojinchao95