Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor : exclude H2 dependency from agent plugins (#23318) #23319

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Refactor : exclude H2 dependency from agent plugins (#23318) #23319

merged 1 commit into from
Jan 4, 2023

Conversation

taojintianxia
Copy link
Contributor

@taojintianxia taojintianxia commented Jan 4, 2023

Fixes #23318.

Changes proposed in this pull request:

  • exclude H2 dependency from agent plugins

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

Local test

Zipkin

image

Metrics

image

@taojintianxia taojintianxia self-assigned this Jan 4, 2023
@taojintianxia taojintianxia added type: dependencies Pull requests that update a dependency file feature: agent shardingsphere agent type: refactor labels Jan 4, 2023
@taojintianxia taojintianxia added this to the 5.3.1 milestone Jan 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #23319 (e3c8d1f) into master (bbcaa32) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master   #23319      +/-   ##
============================================
+ Coverage     49.86%   49.88%   +0.01%     
  Complexity     2455     2455              
============================================
  Files          4029     4030       +1     
  Lines         57876    57893      +17     
  Branches       9190     9194       +4     
============================================
+ Hits          28861    28881      +20     
+ Misses        26463    26460       -3     
  Partials       2552     2552              
Impacted Files Coverage Δ
...shardingsphere/agent/core/ShardingSphereAgent.java 0.00% <0.00%> (ø)
.../yaml/swapper/YamlPluginsConfigurationSwapper.java 85.71% <ø> (ø)
...t/core/config/loader/AgentConfigurationLoader.java 88.88% <100.00%> (ø)
...ore/config/yaml/entity/YamlAgentConfiguration.java 100.00% <100.00%> (ø)
.../MilitaryIdentityNumberRandomReplaceAlgorithm.java 100.00% <0.00%> (ø)
...handler/distsql/ral/hint/enums/HintSourceType.java 42.85% <0.00%> (+42.85%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tristaZero tristaZero merged commit efc6525 into apache:master Jan 4, 2023
@taojintianxia taojintianxia deleted the refactor-H2-exclude branch January 4, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: agent shardingsphere agent type: dependencies Pull requests that update a dependency file type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exclude H2 dependency from agent plugins
3 participants