Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize agent module #23101

Merged
merged 8 commits into from
Dec 26, 2022
Merged

Optimize agent module #23101

merged 8 commits into from
Dec 26, 2022

Conversation

jiangML
Copy link
Contributor

@jiangML jiangML commented Dec 26, 2022

For #23100

Changes proposed in this pull request:

  • Merge agent-core into agent-bootstrap
  • Split TimeRecorder, AgentReflectionUtil, RemotePluginConfigurationValidator into new shardingsphere-agent-plugin-core module
  • Add dependency shade

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@RaigorJiang RaigorJiang added this to the 5.3.1 milestone Dec 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #23101 (6ae7ba7) into master (01f4968) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #23101   +/-   ##
=========================================
  Coverage     49.95%   49.96%           
  Complexity     2433     2433           
=========================================
  Files          4112     4112           
  Lines         57478    57478           
  Branches       9086     9086           
=========================================
+ Hits          28714    28717    +3     
+ Misses        26253    26250    -3     
  Partials       2511     2511           
Impacted Files Coverage Δ
...ingsphere/agent/bootstrap/ShardingSphereAgent.java 0.00% <ø> (ø)
.../agent/bootstrap/classloader/AgentClassLoader.java 17.30% <ø> (ø)
...strap/config/loader/PluginConfigurationLoader.java 88.88% <ø> (ø)
...g/yaml/entity/YamlPluginCategoryConfiguration.java 100.00% <ø> (ø)
...ap/config/yaml/entity/YamlPluginConfiguration.java 100.00% <ø> (ø)
...p/config/yaml/entity/YamlPluginsConfiguration.java 100.00% <ø> (ø)
.../yaml/swapper/YamlPluginsConfigurationSwapper.java 85.71% <ø> (ø)
...gsphere/agent/bootstrap/logging/LoggerFactory.java 47.50% <ø> (ø)
...phere/agent/bootstrap/logging/LoggingListener.java 77.77% <ø> (ø)
...gsphere/agent/bootstrap/path/AgentPathBuilder.java 57.89% <ø> (ø)
... and 39 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sandynz sandynz merged commit c4cd5c6 into apache:master Dec 26, 2022
@jiangML jiangML deleted the optimize-agent-module branch December 26, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants