Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize agent #23068

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Optimize agent #23068

merged 2 commits into from
Dec 23, 2022

Conversation

jiangML
Copy link
Contributor

@jiangML jiangML commented Dec 23, 2022

For #23067

Changes proposed in this pull request:

  • Remove MethodInvocationResult
  • The method afterMethod() of InstanceMethodAdvice and StaticMethodAdvice adds the original execution result as an input parameter

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@codecov-commenter
Copy link

Codecov Report

Merging #23068 (5ef2a12) into master (7677c79) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #23068   +/-   ##
=========================================
  Coverage     50.03%   50.03%           
  Complexity     2424     2424           
=========================================
  Files          4110     4109    -1     
  Lines         57354    57348    -6     
  Branches       9048     9044    -4     
=========================================
+ Hits          28695    28696    +1     
+ Misses        26149    26146    -3     
+ Partials       2510     2506    -4     
Impacted Files Coverage Δ
...ing/base/advice/MetaDataContextsFactoryAdvice.java 0.00% <ø> (ø)
...gent/metrics/core/advice/ChannelHandlerAdvice.java 91.66% <ø> (ø)
...metrics/core/advice/CommandExecutorTaskAdvice.java 85.71% <ø> (ø)
...e/agent/metrics/core/advice/TransactionAdvice.java 90.00% <ø> (ø)
...acing/jaeger/advice/CommandExecutorTaskAdvice.java 100.00% <ø> (ø)
...cing/jaeger/advice/JDBCExecutorCallbackAdvice.java 92.00% <ø> (ø)
...n/tracing/jaeger/advice/SQLParserEngineAdvice.java 100.00% <ø> (ø)
...pentelemetry/advice/CommandExecutorTaskAdvice.java 100.00% <ø> (ø)
...entelemetry/advice/JDBCExecutorCallbackAdvice.java 92.00% <ø> (ø)
...ng/opentelemetry/advice/SQLParserEngineAdvice.java 93.33% <ø> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terrymanu terrymanu added this to the 5.3.1 milestone Dec 23, 2022
@terrymanu terrymanu merged commit 4bc21a3 into apache:master Dec 23, 2022
@jiangML jiangML deleted the optimize-agent branch December 26, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants