Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModeContextManager interface and split ClusterModeContextManager and StandaloneModeContextManager #23061

Merged
merged 8 commits into from
Dec 24, 2022

Conversation

zhaojinchao95
Copy link
Contributor

For #23042

@zhaojinchao95 zhaojinchao95 changed the title Add ModeContextManager and split ClusterModeContextManager and StandaloneModeContextManager Add ModeContextManager interface and split ClusterModeContextManager and StandaloneModeContextManager Dec 23, 2022
@zhaojinchao95 zhaojinchao95 added this to the 5.3.1 milestone Dec 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #23061 (6874a1c) into master (6e5f964) will decrease coverage by 0.06%.
The diff coverage is 33.04%.

@@             Coverage Diff              @@
##             master   #23061      +/-   ##
============================================
- Coverage     50.05%   49.99%   -0.07%     
+ Complexity     2428     2426       -2     
============================================
  Files          4110     4112       +2     
  Lines         57341    57376      +35     
  Branches       9041     9049       +8     
============================================
- Hits          28704    28683      -21     
- Misses        26130    26185      +55     
- Partials       2507     2508       +1     
Impacted Files Coverage Δ
...shardingsphere/infra/instance/InstanceContext.java 35.29% <ø> (ø)
...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java 0.00% <0.00%> (ø)
.../updatable/ImportDatabaseConfigurationHandler.java 18.30% <0.00%> (ø)
...nager/standalone/StandaloneModeContextManager.java 7.69% <7.69%> (ø)
...ode/manager/cluster/ClusterModeContextManager.java 10.00% <10.00%> (ø)
...he/shardingsphere/mode/manager/ContextManager.java 54.23% <70.00%> (+1.44%) ⬆️
.../manager/cluster/ClusterContextManagerBuilder.java 84.37% <100.00%> (+1.61%) ⬆️
...er/standalone/StandaloneContextManagerBuilder.java 84.21% <100.00%> (+4.21%) ⬆️
...handler/database/CreateDatabaseBackendHandler.java 100.00% <100.00%> (ø)
...d/handler/database/DropDatabaseBackendHandler.java 83.33% <100.00%> (ø)
... and 67 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@strongduanmu strongduanmu merged commit 34a5db9 into apache:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants